You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by vladimir-kotikov <gi...@git.apache.org> on 2016/02/18 15:09:24 UTC
[GitHub] cordova-lib pull request: CB-10644 Adds deprecation message about ...
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/394
CB-10644 Adds deprecation message about old platforms support removal
JIRA: [CB-10644](https://issues.apache.org/jira/browse/CB-10644)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-lib CB-10644
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/394.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #394
----
commit ed9b586dc0df3743864aa5f5bc6e8837513eb4fd
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2016-01-22T11:22:35Z
CB-10644 Adds deprecation message about old platforms support removal
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10644 Adds deprecation message about ...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/394#discussion_r53380925
--- Diff: cordova-lib/src/platforms/platforms.js ---
@@ -48,11 +48,17 @@ function getPlatformApi(platform, platformRootDir) {
var PlatformApi;
try {
// First we need to find whether platform exposes its' API via js module
- // If it has, then we have to require it and extend BasePlatformApi
- // with platform's API.
+ // If it does, then we require and instantiate it.
var platformApiModule = path.join(platformRootDir, 'cordova', 'Api.js');
PlatformApi = require(platformApiModule);
} catch (err) {
+ // Check if platform already compatible w/ PlatformApi and show deprecation warning
+ if (err && err.code === 'MODULE_NOT_FOUND' && platforms[platform].apiCompatibleSince) {
+ events.emit('warn', 'The support for cordova-' + platform + ' via PlatformApi polyfill ' +
--- End diff --
instead of leaking internal implementation detail we should consider re-phrasing this as:
"Using this version of cordova CLI with older version of cordova-<platform> is being deprecated. Consider upgrading to..."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10644 Adds deprecation message about ...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/394#issuecomment-186135548
@nikhilkh, updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10644 Adds deprecation message about ...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/394#issuecomment-186313374
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request: CB-10644 Adds deprecation message about ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/394
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org