You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/12/09 23:39:30 UTC
[kudu-CR](branch-1.2.x) KUDU-1798: [env] File manager broken on OS X 10.11
Dan Burkert has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5452
Change subject: KUDU-1798: [env] File manager broken on OS X 10.11
......................................................................
KUDU-1798: [env] File manager broken on OS X 10.11
Env::IncreaseOpenFileLimit() relies upon few system calls which behave
differently on OS X 10.11 than on Linux or other versions of macOS. See
the new comment in env_posix.cc for details.
Change-Id: Idb18b4e52ad80f89f61a92898c50c479643c12ec
Reviewed-on: http://gerrit.cloudera.org:8080/5438
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
(cherry picked from commit 8e1a8c550408bbd9c580d2dfe6fb22ce8e8c958c)
---
M src/kudu/util/env-test.cc
M src/kudu/util/env_posix.cc
2 files changed, 24 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/52/5452/1
--
To view, visit http://gerrit.cloudera.org:8080/5452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idb18b4e52ad80f89f61a92898c50c479643c12ec
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
[kudu-CR](branch-1.2.x) KUDU-1798: [env] File manager broken on OS X 10.11
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: KUDU-1798: [env] File manager broken on OS X 10.11
......................................................................
KUDU-1798: [env] File manager broken on OS X 10.11
Env::IncreaseOpenFileLimit() relies upon few system calls which behave
differently on OS X 10.11 than on Linux or other versions of macOS. See
the new comment in env_posix.cc for details.
Change-Id: Idb18b4e52ad80f89f61a92898c50c479643c12ec
Reviewed-on: http://gerrit.cloudera.org:8080/5438
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
(cherry picked from commit 8e1a8c550408bbd9c580d2dfe6fb22ce8e8c958c)
Reviewed-on: http://gerrit.cloudera.org:8080/5452
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
---
M src/kudu/util/env-test.cc
M src/kudu/util/env_posix.cc
2 files changed, 24 insertions(+), 0 deletions(-)
Approvals:
Jean-Daniel Cryans: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idb18b4e52ad80f89f61a92898c50c479643c12ec
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](branch-1.2.x) KUDU-1798: [env] File manager broken on OS X 10.11
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has posted comments on this change.
Change subject: KUDU-1798: [env] File manager broken on OS X 10.11
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb18b4e52ad80f89f61a92898c50c479643c12ec
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No