You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by an...@apache.org on 2017/10/19 15:04:52 UTC
[mynewt-core] 01/02: Removing use of undefined TASKS_START behavior
This is an automated email from the ASF dual-hosted git repository.
andk pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mynewt-core.git
commit fc0da53f8abedb1c7fce4e35ee565e310e971fdb
Author: Jonathan Seroussi <se...@gmail.com>
AuthorDate: Sun Oct 15 14:58:14 2017 +0300
Removing use of undefined TASKS_START behavior
Tested using the bleprph app. The problem was that the behavior of the RNG TASKS_START is defined to be write only. Reading from it is undefined and though it might have worked up until now doesn't mean it'll constantly work. I was only able to catch on to this using an emulator.
---
hw/drivers/nimble/nrf52/src/ble_hw.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/hw/drivers/nimble/nrf52/src/ble_hw.c b/hw/drivers/nimble/nrf52/src/ble_hw.c
index b97a347..e63ba52 100644
--- a/hw/drivers/nimble/nrf52/src/ble_hw.c
+++ b/hw/drivers/nimble/nrf52/src/ble_hw.c
@@ -344,13 +344,11 @@ ble_hw_rng_start(void)
/* No need for interrupt if there is no callback */
OS_ENTER_CRITICAL(sr);
- if (NRF_RNG->TASKS_START == 0) {
- NRF_RNG->EVENTS_VALRDY = 0;
- if (g_ble_rng_isr_cb) {
- NRF_RNG->INTENSET = 1;
- }
- NRF_RNG->TASKS_START = 1;
+ NRF_RNG->EVENTS_VALRDY = 0;
+ if (g_ble_rng_isr_cb) {
+ NRF_RNG->INTENSET = 1;
}
+ NRF_RNG->TASKS_START = 1;
OS_EXIT_CRITICAL(sr);
return 0;
--
To stop receiving notification emails like this one, please contact
"commits@mynewt.apache.org" <co...@mynewt.apache.org>.