[GitHub] [ignite-3] AMashenkov commented on a change in pull request #509: IGNITE-16128: Implement bulk table operations for non-binary views.

[GitBox <gi...@apache.org>]

AMashenkov commented on a change in pull request #509:
URL: https://github.com/apache/ignite-3/pull/509#discussion_r769542173



##########
File path: modules/table/src/main/java/org/apache/ignite/internal/table/KeyValueViewImpl.java
##########
@@ -133,7 +136,9 @@ public void putAll(@NotNull Map<K, V> pairs) {
     @Override
     public @NotNull
     CompletableFuture<Void> putAllAsync(@NotNull Map<K, V> pairs) {
-        throw new UnsupportedOperationException("Not implemented yet.");
+        Collection<BinaryRow> rows = marshal(Objects.requireNonNull(pairs));
+
+        return tbl.upsertAll(rows, tx);

Review comment:
       Because put() updates an existed row as an upsert() does.
   An insert() ignores existed row, like a putIfAbsent()




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org