You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "dwsmith1983 (via GitHub)" <gi...@apache.org> on 2026/10/04 16:38:13 UTC
[I] Native Azure credential lookup still differs from Hadoop ABFS in a few configurations [datafusion-comet]
dwsmith1983 opened a new issue, #6605:
URL: https://github.com/apache/datafusion-comet/issues/6605
### Describe the bug
The native Parquet scan resolves Azure credentials from the Hadoop `fs.azure.*` settings, and the goal is to pick the identity Hadoop's ABFS driver would. After #6059 a few gaps remain where the two can disagree. None of them comes from #6059; they were found while checking it against Hadoop 3.4.2's `AbfsConfiguration`.
1. **Container-scoped OAuth keys.** Since Hadoop 3.4.2, `getPasswordString` probes `<key>.<container>.<host>` before the account and global forms, and `getTokenProvider` reads the client id, secret and endpoint, the MSI tenant, endpoint and authority, and the token file through it. The native scan reads that form only for the SAS fixed token. With `fs.azure.account.oauth2.client.secret.data.myacct.dfs.core.windows.net` set next to an account-level secret, Hadoop authenticates as the container's principal and the native scan as the account's. With only the container-scoped secret, the native scan fails.
2. **Fabric hosts.** `ENDPOINT_SUFFIXES` lists only the `core.windows.net` suffixes, but `object_store` also accepts `onelake.dfs.fabric.microsoft.com`. Account-scoped keys for a Fabric host are never found, so a configured principal is missed and the scan falls through to ambient `AZURE_*` variables or managed identity.
3. **Account-scoped key forms.** Hadoop's `accountConf` builds `<key>.<host>` from the raw URL authority, port included. The native scan also probes the other endpoint suffix and the short `<key>.<account>` form, ahead of the global key, and drops an explicit port. A stale key Hadoop never reads can therefore win over the global one.
4. **Credential provider stores.** `Configuration.getPassword` consults `hadoop.security.credential.provider.path` (for example JCEKS) before plain configuration. The native scan only sees plain configuration, so a token kept in a store is invisible and a lower-priority plaintext value is used instead.
5. **OAuth provider class lookup.** `fs.azure.account.oauth.provider.type` does not apply the `getTokenProviderClass` auth-type guard that the SAS provider class now does. Hadoop fails ("Failed to initialize null") where the native scan builds a store, so this only matters if the driver path changes.
6. **Error text.** The "Scheme of URL is not Azure" error formats the whole URL, which would echo a password in the userinfo.
### Steps to reproduce
Unit-level: build the store with `create_store_with_env` and an empty environment for each configuration above, and compare with what Hadoop 3.4.2 `AbfsConfiguration` resolves.
### Expected behavior
The native scan either resolves the same credential Hadoop does or fails with an error naming the key, and never falls through to the environment when Hadoop configured a mechanism.
### Additional context
Hadoop 3.4.1 and older have no container-scoped lookup at all, so items 1 and 3 depend on the Hadoop version on the driver.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Native Azure credential lookup still differs from Hadoop ABFS in a few configurations [datafusion-comet]
Posted by "dwsmith1983 (via GitHub)" <gi...@apache.org>.
dwsmith1983 commented on issue #6605:
URL: https://github.com/apache/datafusion-comet/issues/6605#issuecomment-6289487081
Where each item stands, for closing this with #7127.
#6059 moved Azure credential resolution to the driver: `AbfsAuthResolver` builds hadoop-azure's own `AbfsConfiguration` from the URL's authority and calls `getPasswordString`, `getTokenProviderClass` and `getTokenProvider`. The native store now reads only the global keys the driver sends. `AbfsAuthParitySuite` checks each case against the real `AzureBlobFileSystem`, pinned per hadoop-azure version in `abfs-auth-parity/expected-<version>.json`.
1. Container-scoped OAuth keys: covered by #6059. Parity cases `oauth-clientcreds-container-secret`, `oauth-msi-container-tenant`, `oauth-wi-container-token-file`, `cal-sas-container-fixed-token` and `cal-container-oauth-endpoint`, which resolve the container's principal on 3.4.2 and the account's on 3.4.1.
2. Fabric hosts: covered by #6059 by construction. The native endpoint-suffix list is gone, and Hadoop looks keys up under the URL's own authority. There is no Fabric parity case.
3. Account-scoped key forms: covered by #6059. A port in the account is tested (`uri-port-in-account`, `cal-port-key-matches`, `cal-port-key-missing`). The other host-suffix and short `<key>.<account>` forms follow from Hadoop doing the lookup; no case pins them directly.
4. Credential provider stores: covered by #6059. The `cp-jceks-*` cases, including a keystore value winning over a clear-text key.
5. OAuth provider class guard: covered by #6059. `oauth-no-provider-type` and the guard cases fail the way Hadoop does on every version.
6. Error text: #7127.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Native Azure credential lookup still differs from Hadoop ABFS in a few configurations [datafusion-comet]
Posted by "dwsmith1983 (via GitHub)" <gi...@apache.org>.
dwsmith1983 commented on issue #6605:
URL: https://github.com/apache/datafusion-comet/issues/6605#issuecomment-6286334518
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Native Azure credential lookup still differs from Hadoop ABFS in a few configurations [datafusion-comet]
Posted by "andygrove (via GitHub) via github" <gi...@datafusion.apache.org>.
andygrove closed issue #6605: Native Azure credential lookup still differs from Hadoop ABFS in a few configurations
URL: https://github.com/apache/datafusion-comet/issues/6605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org