You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/14 17:47:16 UTC

[GitHub] [arrow] jonkeane commented on a change in pull request #9205: ARROW-11253 [R]: Make sure that large metadata tests are reproducible

jonkeane commented on a change in pull request #9205:
URL: https://github.com/apache/arrow/pull/9205#discussion_r557579022



##########
File path: r/tests/testthat/test-backwards-compatibility.R
##########
@@ -50,7 +50,15 @@ test_that("reading a known Parquet file to dataframe with 3.0.0", {
   pq_file <- test_path("golden-files/data-arrow-extra-meta_3.0.0.parquet")
 
   df <- read_parquet(pq_file)
-  # this is equivalent to `expect_identical()`
+
+  # test the shape (but not the contents of) the column-level attributes for the
+  # large column since those are random and seed changes will make them different

Review comment:
       They don't necessarily have to be, but I was following the pattern in [`make_big_string()`](https://github.com/apache/arrow/blob/master/r/tests/testthat/helper-data.R#L66-L69)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org