You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "rorueda (via GitHub)" <gi...@apache.org> on 2024/03/21 19:20:54 UTC
[PR] [MINOR][DOCS] Fix typo in spark connect overview [spark]
rorueda opened a new pull request, #45650:
URL: https://github.com/apache/spark/pull/45650
### What changes were proposed in this pull request?
Fix typo in the command to install the `spark-connect-repl` by substituting the `en-dash` char by the `hyphen-minus`.
### Why are the changes needed?
It doesn't work with the `en-dash`.
### Does this PR introduce _any_ user-facing change?
Only documentation.
### How was this patch tested?
The documentation was built and the output checked manually.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Fix typo in spark connect overview [spark]
Posted by "rorueda (via GitHub)" <gi...@apache.org>.
rorueda commented on PR #45650:
URL: https://github.com/apache/spark/pull/45650#issuecomment-2014937149
@HyukjinKwon
I'm sorry, I only did it after pushing. I had to force-push to trigger the actions.
@dongjoon-hyun
I have found other instances in the documentation, but in places where they are all valid.
I think it would be challenging to prevent only the invalid ones as even in a shell snippet they might be valid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Fix typo in spark connect overview [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #45650:
URL: https://github.com/apache/spark/pull/45650#issuecomment-2015253967
Merged to master for Apache Spark 4.0.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Fix typo in spark connect overview [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #45650: [MINOR][DOCS] Fix typo in spark connect overview
URL: https://github.com/apache/spark/pull/45650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][DOCS] Fix typo in spark connect overview [spark]
Posted by "RocMarshal (via GitHub)" <gi...@apache.org>.
RocMarshal commented on PR #45650:
URL: https://github.com/apache/spark/pull/45650#issuecomment-2014414821
Hi, @dongjoon-hyun Could you help take a look ? thank you~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org