You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/12/27 17:31:22 UTC
[GitHub] [skywalking-website] Jtrust opened a new pull request #187: Add Tags feature
Jtrust opened a new pull request #187:
URL: https://github.com/apache/skywalking-website/pull/187
- [x] Add `Tags` feature
demo screenshots:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Jtrust commented on pull request #187: Add Tags feature
Posted by GitBox <gi...@apache.org>.
Jtrust commented on pull request #187:
URL: https://github.com/apache/skywalking-website/pull/187#issuecomment-753632352
> And the tags mixed with Chinese and English blogs, this should be fixed.
I'm sorry I haven't yet found a way to distinguish between Chinese and English blog tags. I'm going to submit it later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Jtrust edited a comment on pull request #187: Add Tags feature
Posted by GitBox <gi...@apache.org>.
Jtrust edited a comment on pull request #187:
URL: https://github.com/apache/skywalking-website/pull/187#issuecomment-753632352
> And the tags mixed with Chinese and English blogs, this should be fixed.
I'm sorry I haven't yet found a way to distinguish between Chinese and English blog tags. I'm going to commit it later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Jtrust commented on pull request #187: Add Tags feature
Posted by GitBox <gi...@apache.org>.
Jtrust commented on pull request #187:
URL: https://github.com/apache/skywalking-website/pull/187#issuecomment-753467302
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on pull request #187: Add Tags feature
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #187:
URL: https://github.com/apache/skywalking-website/pull/187#issuecomment-753791172
> I wonder if there are any users interested in both Chinese and English? Having a page width all tags summary, maybe you can get to the tag list page more conveniently?
Maybe there is, but would not be many of them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Jtrust commented on pull request #187: Add Tags feature
Posted by GitBox <gi...@apache.org>.
Jtrust commented on pull request #187:
URL: https://github.com/apache/skywalking-website/pull/187#issuecomment-753606663
> Some is not formatted correctly.
When wrapping lines, what about this style？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Jtrust commented on pull request #187: Add Tags feature
Posted by GitBox <gi...@apache.org>.
Jtrust commented on pull request #187:
URL: https://github.com/apache/skywalking-website/pull/187#issuecomment-754104717
blogs tags:
zh tags:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on pull request #187: Add Tags feature
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #187:
URL: https://github.com/apache/skywalking-website/pull/187#issuecomment-753586458
And the tags mixed with Chinese and English blogs, this should be fixed.
Another issue is, could you make this more like tags? Start the line with `Tags` and an icon?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on pull request #187: Add Tags feature
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #187:
URL: https://github.com/apache/skywalking-website/pull/187#issuecomment-753585582
Some is not formatted correctly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on pull request #187: Add Tags feature
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #187:
URL: https://github.com/apache/skywalking-website/pull/187#issuecomment-751531094
Could we show the available tags at the side of blog page, like this? https://www.tetrate.io/blog/
We should use the tags to filter the blog list, with paging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on pull request #187: Add Tags feature
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #187:
URL: https://github.com/apache/skywalking-website/pull/187#issuecomment-753731731
The blog(cn/en) pages are fixed, but still, when I click a tag, cn/en are still mixed.
From my understanding, you could take these two pages are totally unrelated, because their readers are not same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on a change in pull request #187: Add Tags feature
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #187:
URL: https://github.com/apache/skywalking-website/pull/187#discussion_r549178082
##########
File path: content/blog/e2e-design/index.md
##########
@@ -3,6 +3,9 @@ title: "[Design] NGE2E - Next Generation End-to-End Testing Framework"
date: 2020-12-14
author: "[Zhenxu Ke](https://github.com/kezhenxu94), Tetrate.io; [Huaxi Jiang](http://github.com/fgksgf), Committer; [Ke Zhang](http://github.com/HumbertZhang), Committer"
description: "The design of Next Generation End-to-End Testing Framework"
+
+tags:
+- Framework
Review comment:
```suggestion
- e2e
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Jtrust commented on pull request #187: Add Tags feature
Posted by GitBox <gi...@apache.org>.
Jtrust commented on pull request #187:
URL: https://github.com/apache/skywalking-website/pull/187#issuecomment-753740770
> The blog(cn/en) pages are fixed, but still, when I click a tag, cn/en are still mixed.
> 
>
> From my understanding, you could take these two pages are totally unrelated, because their readers are not same.
I was thinking that when you click on a tag, the tags page sidebar should show all tags and the tags should be in English or Chinese(Chinese blogs show Tags in Chinese)
I wonder if there are any users interested in both Chinese and English? Having a page width all tags summary, maybe you can get to the tag list page more quickly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on pull request #187: Add Tags feature
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #187:
URL: https://github.com/apache/skywalking-website/pull/187#issuecomment-751530631
Seems you are using static links, at the netlify preview page, it costs 404
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng merged pull request #187: Add Tags feature
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #187:
URL: https://github.com/apache/skywalking-website/pull/187
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on a change in pull request #187: Add Tags feature
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #187:
URL: https://github.com/apache/skywalking-website/pull/187#discussion_r549178169
##########
File path: content/zh/2020-12-20-summer2020-activity-sharing2/index.md
##########
@@ -3,6 +3,8 @@ title: 暑期 2020 活动学生（张可）心得分享
date: 2020-12-20
author: 张可
description: 学生（张可）参与暑期 2020 活动中 Apache SkyWalking 项目的感受与收获
+tags:
+- SkyWalking
Review comment:
```suggestion
- Open Source Promotion Plan
```
Could the tag name be multiple words?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on a change in pull request #187: Add Tags feature
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #187:
URL: https://github.com/apache/skywalking-website/pull/187#discussion_r549178250
##########
File path: content/blog/2019-01-25-mesh-loadtest/index.md
##########
@@ -3,6 +3,9 @@ title: "SkyWalking performance in Service Mesh scenario"
date: 2019-01-25
author: Hongtao Gao(Tetrate)
description: "Service mesh receiver performance test on Google Kubernetes Engine."
+tags:
+- SkyWalking
Review comment:
```suggestion
```
We should not add `skywalking` tag, all things on our website are skywalking related.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Jtrust edited a comment on pull request #187: Add Tags feature
Posted by GitBox <gi...@apache.org>.
Jtrust edited a comment on pull request #187:
URL: https://github.com/apache/skywalking-website/pull/187#issuecomment-753740770
> The blog(cn/en) pages are fixed, but still, when I click a tag, cn/en are still mixed.
> 
>
> From my understanding, you could take these two pages are totally unrelated, because their readers are not same.
I was thinking that when you click on a tag, the tags page sidebar should show all tags and the tags should be in English or Chinese(Chinese blogs show Tags in Chinese)
I wonder if there are any users interested in both Chinese and English? Having a page width all tags summary, maybe you can get to the tag list page more conveniently?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on pull request #187: Add Tags feature
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #187:
URL: https://github.com/apache/skywalking-website/pull/187#issuecomment-753467513
Could you make the tag list shows up on `/blog/` too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Jtrust commented on pull request #187: Add Tags feature
Posted by GitBox <gi...@apache.org>.
Jtrust commented on pull request #187:
URL: https://github.com/apache/skywalking-website/pull/187#issuecomment-753467403
> Seems you are using static links, at the netlify preview page, it costs 404
The problem is still being solved
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Jtrust commented on pull request #187: Add Tags feature
Posted by GitBox <gi...@apache.org>.
Jtrust commented on pull request #187:
URL: https://github.com/apache/skywalking-website/pull/187#issuecomment-753643694
screenshots
<img width="1227" alt="企业微信20210104-003611@2x" src="https://user-images.githubusercontent.com/21056967/103483862-26676980-4e25-11eb-863a-468ce5cf8aa9.png">
<img width="1225" alt="企业微信20210104-003635@2x" src="https://user-images.githubusercontent.com/21056967/103483867-2bc4b400-4e25-11eb-9bbc-5cd301529c14.png">
<img width="1225" alt="企业微信20210104-003729@2x" src="https://user-images.githubusercontent.com/21056967/103483869-2e270e00-4e25-11eb-9f44-45a808c86a62.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on pull request #187: Add Tags feature
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #187:
URL: https://github.com/apache/skywalking-website/pull/187#issuecomment-754293956
Great, I am going to merge this PR and update the tags. Thanks @Jtrust
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Jtrust commented on pull request #187: Add Tags feature
Posted by GitBox <gi...@apache.org>.
Jtrust commented on pull request #187:
URL: https://github.com/apache/skywalking-website/pull/187#issuecomment-753582001
> > Seems you are using static links, at the netlify preview page, it costs 404
>
> The problem is still being solved
I changed `baseURL` of `config.toml` file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on a change in pull request #187: Add Tags feature
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #187:
URL: https://github.com/apache/skywalking-website/pull/187#discussion_r549178273
##########
File path: content/blog/2019-01-01-Understand-Trace/index.md
##########
@@ -3,6 +3,9 @@ title: "Understand distributed trace easier in the incoming 6-GA"
date: 2019-01-01
author: Wu Sheng(Tetrate)
description: "Distributed tracing is a necessary part of modern microservices architecture, but how to understand or use distributed tracing data is unclear to some end users. This blog overviews typical distributed tracing use cases with new visualization features in SkyWalking v6."
+
+tags:
+- SkyWalking
Review comment:
```suggestion
- tracing
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Jtrust commented on pull request #187: Add Tags feature
Posted by GitBox <gi...@apache.org>.
Jtrust commented on pull request #187:
URL: https://github.com/apache/skywalking-website/pull/187#issuecomment-753467785
> Could you make the tag list shows up on `/blog/` too?
👌
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] wu-sheng commented on a change in pull request #187: Add Tags feature
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #187:
URL: https://github.com/apache/skywalking-website/pull/187#discussion_r549178101
##########
File path: content/zh/2018-05-24-skywalking-net/index.md
##########
@@ -3,6 +3,8 @@ title: "Apache SkyWalking 为.NET Core带来开箱即用的分布式追踪和应
date: 2018-05-24
author: 刘浩扬（SkyWalking .NET Core 探针维护者）
description: "SkyWalking .NET Core SDK 现已可用。"
+tags:
+- Apache
Review comment:
```suggestion
- DotNet
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-website] Jtrust commented on pull request #187: Add Tags feature
Posted by GitBox <gi...@apache.org>.
Jtrust commented on pull request #187:
URL: https://github.com/apache/skywalking-website/pull/187#issuecomment-751536688
> Could we show the available tags at the side of blog page, like this? https://www.tetrate.io/blog/
> We should use the tags to filter the blog list, with paging.
It looks nice！
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org