Re: [PR] MINOR: [C++][Compute] Remove processing logic for ArrayData as ExecResults in ExecScalarCaseWhen [arrow]

["bkietz (via GitHub)" <gi...@apache.org>]

bkietz commented on code in PR #41380:
URL: https://github.com/apache/arrow/pull/41380#discussion_r1586597414


##########
cpp/src/arrow/compute/kernels/scalar_if_else.cc:
##########
@@ -1482,39 +1482,21 @@ Status ExecScalarCaseWhen(KernelContext* ctx, const ExecSpan& batch, ExecResult*
     result = temp.get();
   }
 
-  // TODO(wesm): clean this up to have less duplication
-  if (out->is_array_data()) {

Review Comment:
   Please add this explanation and a `DCHECK(out->is_array_data());` (even if there is no way to arrive at this point with arraydata *currently*, later changes may produce one and the assertion will help us catch that)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org