[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #22960: Table mode cannot be verified by automatic sharding algorithm

[GitBox <gi...@apache.org>]

RaigorJiang commented on code in PR #22960:
URL: https://github.com/apache/shardingsphere/pull/22960#discussion_r1056822592


##########
features/sharding/distsql/handler/src/test/java/org/apache/shardingsphere/sharding/distsql/fixture/sharding/HintInlineShardingAlgorithmFixture.java:
##########
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sharding.distsql.fixture.sharding;
+
+import com.google.common.base.Preconditions;
+import groovy.lang.Closure;
+import groovy.util.Expando;
+import lombok.Getter;
+import org.apache.shardingsphere.infra.util.expr.InlineExpressionParser;
+import org.apache.shardingsphere.sharding.api.sharding.hint.HintShardingAlgorithm;
+import org.apache.shardingsphere.sharding.api.sharding.hint.HintShardingValue;
+
+import java.util.Collection;
+import java.util.Properties;
+import java.util.stream.Collectors;
+
+/**
+ * Hint inline sharding algorithm.
+ */
+public final class HintInlineShardingAlgorithmFixture implements HintShardingAlgorithm<Comparable<?>> {
+    
+    private static final String ALGORITHM_EXPRESSION_KEY = "algorithm-expression";
+    
+    private static final String DEFAULT_ALGORITHM_EXPRESSION = "${value}";
+    
+    private static final String HINT_INLINE_VALUE_PROPERTY_NAME = "value";
+    
+    @Getter
+    private Properties props = new Properties();
+    
+    private String algorithmExpression;
+    
+    @Override
+    public void init(final Properties props) {
+        this.props = props;
+        algorithmExpression = getAlgorithmExpression(props);
+    }
+    
+    private String getAlgorithmExpression(final Properties props) {
+        String algorithmExpression = props.getProperty(ALGORITHM_EXPRESSION_KEY, DEFAULT_ALGORITHM_EXPRESSION);
+        Preconditions.checkNotNull(algorithmExpression, "Inline sharding algorithm expression can not be null.");
+        return InlineExpressionParser.handlePlaceHolder(algorithmExpression.trim());
+    }
+    
+    @Override
+    public Collection<String> doSharding(final Collection<String> availableTargetNames, final HintShardingValue<Comparable<?>> shardingValue) {
+        return shardingValue.getValues().isEmpty() ? availableTargetNames : shardingValue.getValues().stream().map(this::doSharding).collect(Collectors.toList());
+    }
+    
+    private String doSharding(final Comparable<?> shardingValue) {
+        Closure<?> closure = createClosure();
+        closure.setProperty(HINT_INLINE_VALUE_PROPERTY_NAME, shardingValue);
+        return closure.call().toString();
+    }
+    
+    private Closure<?> createClosure() {
+        Closure<?> result = new InlineExpressionParser(algorithmExpression).evaluateClosure().rehydrate(new Expando(), null, null);
+        result.setResolveStrategy(Closure.DELEGATE_ONLY);
+        return result;
+    }
+    
+    @Override
+    public String getType() {
+        return "HINT_INLINE";

Review Comment:
   Sorry for being late, why do we need to add `HINT_INLINE`, `INLINE`, `MOD` algorithms, can the built-in algorithms not be used?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org