You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by chrskrchr <gi...@git.apache.org> on 2015/04/20 15:14:51 UTC
[GitHub] cordova-plugin-splashscreen pull request: CB-8875 execute entire c...
GitHub user chrskrchr opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/44
CB-8875 execute entire call to [UIView transitionWithView] on the main t...
...hread so that view fades as expected
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chrskrchr/cordova-plugin-splashscreen master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-splashscreen/pull/44.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #44
----
commit e9cafeddce7d3d2f9312196894a8942e382b0773
Author: Chris Karcher <ch...@chriskarcher.net>
Date: 2015-04-20T13:07:31Z
CB-8875 execute entire call to [UIView transitionWithView] on the main thread so that view fades as expected
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8875 execute entire c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/44
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8875 execute entire c...
Posted by idpaterson <gi...@git.apache.org>.
Github user idpaterson commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/44#issuecomment-131947531
Should the `createViews` and `destroyViews` calls (the entire if/else structure) be dispatched to the main thread as well? It seems that calling those off of the main thread could lead to unexpected behavior since they interact with views.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org