You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pirk.apache.org by tellison <gi...@git.apache.org> on 2016/08/30 15:51:40 UTC
[GitHub] incubator-pirk pull request #83: Pass query elements into Query constructor.
GitHub user tellison opened a pull request:
https://github.com/apache/incubator-pirk/pull/83
Pass query elements into Query constructor.
- Compute encrypted query elements, and pass in as part of query
construction rather than adding them afterwards to an existing query.
- Other minor tidy-up, using interfaces, renaming boolean returning
methods for exp tables.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tellison/incubator-pirk QueryElements
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-pirk/pull/83.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #83
----
commit 40fcdebeb90ee00f5b16c2bb6499249fda76463b
Author: Tim Ellison <t....@gmail.com>
Date: 2016-08-30T15:34:20Z
Pass query elements into Query constructor.
- Compute encrypted query elements and pass in as part of query
construction, rather than adding them to an existing query.
- Other minor tidy-up, using interfaces, renaming boolean returning
methods for exp tables.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk issue #83: Pass query elements into Query constructor.
Posted by ellisonanne <gi...@git.apache.org>.
Github user ellisonanne commented on the issue:
https://github.com/apache/incubator-pirk/pull/83
+1 - will merge now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk pull request #83: Pass query elements into Query constructor.
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-pirk/pull/83
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-pirk issue #83: Pass query elements into Query constructor.
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the issue:
https://github.com/apache/incubator-pirk/pull/83
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---