[jira] [Commented] (KAFKA-4424) Make serializer classes final

["Michael Andre Pearce (IG) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-4424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15681447#comment-15681447 ] 

Michael Andre Pearce (IG) commented on KAFKA-4424:
--------------------------------------------------

Is there a supporting test to prove a significant performance improvement in an end 2 end setup after jit/jvm warm up? 

Obvious reasons is that this would break any code in organisations thats extended this as its part of the client api, so to make this change needs to prove a significant performance improvement % to warrant breaking these.

> Make serializer classes final
> -----------------------------
>
>                 Key: KAFKA-4424
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4424
>             Project: Kafka
>          Issue Type: Improvement
>          Components: clients
>            Reporter: Matthias Bechtold
>            Priority: Minor
>
> Implementations of simple serializers / deserializers should be final to prevent JVM method call overhead.
> See also:
> https://wiki.openjdk.java.net/display/HotSpot/VirtualCalls
> This breaks the API slightly, inheritors must change to generic interfaces Serializer / Deserializer. But architecture-wise final serialization classes make the most sense to me.
> So what do you think?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)