You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/08/22 12:38:46 UTC
[GitHub] [kafka] khaireddine120 opened a new pull request #9207: Minor remove semicolon
khaireddine120 opened a new pull request #9207:
URL: https://github.com/apache/kafka/pull/9207
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] khaireddine120 commented on pull request #9207: Minor remove semicolon
Posted by GitBox <gi...@apache.org>.
khaireddine120 commented on pull request #9207:
URL: https://github.com/apache/kafka/pull/9207#issuecomment-682442638
Hi @bbejeck
Thanks for the approval
Why the check is taking so long ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck commented on pull request #9207: Minor remove semicolon
Posted by GitBox <gi...@apache.org>.
bbejeck commented on pull request #9207:
URL: https://github.com/apache/kafka/pull/9207#issuecomment-685790819
@khaireddine120 can you rebase this PR against trunk? Then after the build we can get this merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck merged pull request #9207: Minor remove semicolon
Posted by GitBox <gi...@apache.org>.
bbejeck merged pull request #9207:
URL: https://github.com/apache/kafka/pull/9207
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck merged pull request #9207: Minor remove semicolon
Posted by GitBox <gi...@apache.org>.
bbejeck merged pull request #9207:
URL: https://github.com/apache/kafka/pull/9207
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck commented on pull request #9207: Minor remove semicolon
Posted by GitBox <gi...@apache.org>.
bbejeck commented on pull request #9207:
URL: https://github.com/apache/kafka/pull/9207#issuecomment-691481266
Minor cleanup, I ran the tests locally and all passed, merging this now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck commented on pull request #9207: Minor remove semicolon
Posted by GitBox <gi...@apache.org>.
bbejeck commented on pull request #9207:
URL: https://github.com/apache/kafka/pull/9207#issuecomment-681005444
Tests seem to be hung, retesting
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] khaireddine120 commented on pull request #9207: Minor remove semicolon
Posted by GitBox <gi...@apache.org>.
khaireddine120 commented on pull request #9207:
URL: https://github.com/apache/kafka/pull/9207#issuecomment-691693535
welcome, i will try to participate more in the future ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck commented on pull request #9207: Minor remove semicolon
Posted by GitBox <gi...@apache.org>.
bbejeck commented on pull request #9207:
URL: https://github.com/apache/kafka/pull/9207#issuecomment-691481266
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck merged pull request #9207: Minor remove semicolon
Posted by GitBox <gi...@apache.org>.
bbejeck merged pull request #9207:
URL: https://github.com/apache/kafka/pull/9207
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck commented on pull request #9207: Minor remove semicolon
Posted by GitBox <gi...@apache.org>.
bbejeck commented on pull request #9207:
URL: https://github.com/apache/kafka/pull/9207#issuecomment-691481266
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck commented on pull request #9207: Minor remove semicolon
Posted by GitBox <gi...@apache.org>.
bbejeck commented on pull request #9207:
URL: https://github.com/apache/kafka/pull/9207#issuecomment-678681668
Ok to test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] bbejeck commented on pull request #9207: Minor remove semicolon
Posted by GitBox <gi...@apache.org>.
bbejeck commented on pull request #9207:
URL: https://github.com/apache/kafka/pull/9207#issuecomment-691481426
Thanks for the cleanup @khaireddine120!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org