[GitHub] [gobblin] sv2000 commented on a change in pull request #3259: [GOBBLIN-1423] Add config to Event reporter to control queue capacity…

[GitBox <gi...@apache.org>]

sv2000 commented on a change in pull request #3259:
URL: https://github.com/apache/gobblin/pull/3259#discussion_r614224509



##########
File path: gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/reporter/EventReporter.java
##########
@@ -189,13 +212,20 @@ public void run() {
     protected MetricFilter filter;
     protected TimeUnit rateUnit;
     protected TimeUnit durationUnit;
+    protected Config config;
 
     protected Builder(MetricContext context) {
       this.context = context;
       this.name = "MetricReportReporter";
       this.rateUnit = TimeUnit.SECONDS;
       this.durationUnit = TimeUnit.MILLISECONDS;
       this.filter = MetricFilter.ALL;
+      this.config = ConfigFactory.empty();
+    }
+
+    public T withConfig(Config config) {

Review comment:
       Should we be more explicit and have methods withQueueCapacity(int) and withReportingInterval(int)? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org