[GitHub] igormartsekha commented on a change in pull request #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?

[gi...@git.apache.org]

igormartsekha commented on a change in pull request #326: CB-12940: [IOS] Use deployment-target from config.xml for platform ve?
URL: https://github.com/apache/cordova-ios/pull/326#discussion_r132825735
 
 

 ##########
 File path: bin/templates/scripts/cordova/lib/Podfile.js
 ##########
 @@ -98,8 +98,8 @@ Podfile.prototype.getTemplate = function () {
     var projectName = this.escapeSingleQuotes(this.projectName);
     return util.format(
         '# DO NOT MODIFY -- auto-generated by Apache Cordova\n' +
-        'platform :ios, \'8.0\'\n' +
-        'target \'%s\' do\n' +
+        'platform :ios, \'%s\'\n' +
+        'use_frameworks!\n' +
 
 Review comment:
   It doesn't allow to add swift libraries in Podfile. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org