You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2017/09/19 22:44:42 UTC
[kudu-CR] docs: add a blurb about faststring usage
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/8106
to review the following change.
Change subject: docs: add a blurb about faststring usage
......................................................................
docs: add a blurb about faststring usage
Change-Id: I009013f1560482751690b6382ed23c5848650211
---
M docs/contributing.adoc
1 file changed, 20 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/8106/1
--
To view, visit http://gerrit.cloudera.org:8080/8106
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I009013f1560482751690b6382ed23c5848650211
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
[kudu-CR] docs: add a blurb about faststring usage
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.
Change subject: docs: add a blurb about faststring usage
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8106/1/docs/contributing.adoc
File docs/contributing.adoc:
PS1, Line 296: it
: the data is stored inline
phrasing. maybe remove "it"?
--
To view, visit http://gerrit.cloudera.org:8080/8106
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I009013f1560482751690b6382ed23c5848650211
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] docs: add a blurb about faststring usage
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: docs: add a blurb about faststring usage
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8106/1/docs/contributing.adoc
File docs/contributing.adoc:
PS1, Line 296: small
Can we quantify this? Under 32 bytes, right?
PS1, Line 296: it
: the
its?
--
To view, visit http://gerrit.cloudera.org:8080/8106
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I009013f1560482751690b6382ed23c5848650211
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes