You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/07/22 01:08:00 UTC

[jira] [Work logged] (HADOOP-17812) NPE when reading s3a

     [ https://issues.apache.org/jira/browse/HADOOP-17812?focusedWorklogId=626390&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-626390 ]

ASF GitHub Bot logged work on HADOOP-17812:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Jul/21 01:07
            Start Date: 22/Jul/21 01:07
    Worklog Time Spent: 10m 
      Work Description: wbo4958 opened a new pull request #3222:
URL: https://github.com/apache/hadoop/pull/3222


   When IOException happens during "wrappedStream.read", onReadFailure->reopen
   will be called and reopen will try to re-open "wrappedStream", but what if
   exception happens during getting S3Object, then "wrappedStream" will be null,
   finally, the "retry" may re-execute the read block and cause the NPE.
   
   See the issue https://issues.apache.org/jira/browse/HADOOP-17812
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 626390)
    Remaining Estimate: 0h
            Time Spent: 10m

> NPE when reading s3a
> --------------------
>
>                 Key: HADOOP-17812
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17812
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: tools
>            Reporter: Bobby Wang
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> when [reading from S3a storage|https://github.com/apache/hadoop/blob/rel/release-3.2.0/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AInputStream.java#L450], SSLException (which extends IOException) happens, which will trigger [onReadFailure|https://github.com/apache/hadoop/blob/rel/release-3.2.0/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AInputStream.java#L458].
> onReadFailure calls "reopen". it will first close the original *wrappedStream* and set *wrappedStream = null*, and then it will try to [re-get *wrappedStream*|https://github.com/apache/hadoop/blob/rel/release-3.2.0/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AInputStream.java#L184]. But what if the previous code [obtaining S3Object|https://github.com/apache/hadoop/blob/rel/release-3.2.0/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AInputStream.java#L183] throw exception, then "wrappedStream" will be null.
> And the [retry|https://github.com/apache/hadoop/blob/rel/release-3.2.0/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AInputStream.java#L446] mechanism may re-execute the [wrappedStream.read|https://github.com/apache/hadoop/blob/rel/release-3.2.0/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AInputStream.java#L450] and cause NPE.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org