[jira] [Commented] (GORA-66) testDeleteByQueryFields seems incorrect

["Apostolos Giannakidis (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GORA-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13736367#comment-13736367 ] 

Apostolos Giannakidis commented on GORA-66:
-------------------------------------------

Hey,

I am bringing this issue up because I face the same issue while developing the Gora - Oracle NoSQL datastore. I completely agree with Keith's point that the endKey should be inclusive and the test should change as Keith describes. On the other hand, if I implement the endKey as exclusive, then testQueryEndKey() and testQueryKeyRange() fails, which implies that endKey should be inclusive.
Please note that this issue is a blocking issue for properly implementing the deleteByQuery() method.

Apos
                
> testDeleteByQueryFields seems incorrect
> ---------------------------------------
>
>                 Key: GORA-66
>                 URL: https://issues.apache.org/jira/browse/GORA-66
>             Project: Apache Gora
>          Issue Type: Bug
>    Affects Versions: 0.2
>            Reporter: Keith Turner
>             Fix For: 0.4
>
>         Attachments: GORA-66-1.patch
>
>
> While writing the Accumulo backend I have been trying to run some of the existing test against it.  It seems that the test DataStoreTestUtil.testDeleteByQueryFields() has two problems.
>  * The test does not flush the store after calling deleteByQuery().  This is needed for accumulo since deletes are just inserts and must be flushed.
>  * The test expects the last key in a range that was deleted to be present.  As far as I can tell the end key in a query should be inclusive, but the test treats as exclusive.
> I will submit a patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira