[GitHub] [cassandra] ekaterinadimitrova2 commented on a diff in pull request #2320: CASSANDRA-18467: ant generate-idea-files support for JDK 17

["ekaterinadimitrova2 (via GitHub)" <gi...@apache.org>]

ekaterinadimitrova2 commented on code in PR #2320:
URL: https://github.com/apache/cassandra/pull/2320#discussion_r1246829274


##########
build.xml:
##########
@@ -1808,11 +1816,21 @@
     <option name="ADDITIONAL_OPTIONS_STRING" value="--add-exports java.rmi/sun.rmi.registry=ALL-UNNAMED" />
   </component>
 </project>]]></echo>
-      <echo>"IDE configuration updated for use with JDK11"</echo>
+      <echo>"IDE configuration updated for use with JDK${ant.java.version}"</echo>
+      <echo>Please note that `ant realclean` does *NOT* remove IntelliJ-specific files</echo>
+      <echo/>
+      <echo>Warning! If you observer strange behavior in IntelliJ please</echo>
+      <echo>verify that the SDK that is being used is indeed version ${ant.java.version}.</echo>
+      <echo>The used JDK version can be verified in Project Structure/Project Setting/Project</echo>
+      <echo>and Project Structure/Platform Setting/SDKs</echo>
+      <echo>In particular it is worth checking if the used JDK, typically named "${ant.java.version}",</echo>
+      <echo>indeed points to a java ${ant.java.version} installation.</echo>
   </target>
 
   <!-- Generate IDEA project description files -->
   <target name="generate-idea-files" depends="init,resolver-dist-lib,gen-cql3-grammar,generate-jflex-java,createVersionPropFile" description="Generate IDEA files">
+    <delete dir=".idea"/>

Review Comment:
   Agreed here with @michaelsembwever 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org