[GitHub] [fineract] hmg65 commented on a diff in pull request #2665: FINERACT-1777: Introduce Lombok to provisioning module

[GitBox <gi...@apache.org>]

hmg65 commented on code in PR #2665:
URL: https://github.com/apache/fineract/pull/2665#discussion_r996280265


##########
fineract-provider/src/main/java/org/apache/fineract/organisation/provisioning/data/ProvisioningCriteriaData.java:
##########
@@ -21,19 +21,27 @@
 import java.io.Serializable;
 import java.util.Collection;
 import java.util.List;
+import lombok.Data;
+import lombok.NoArgsConstructor;
+import lombok.experimental.Accessors;
 import org.apache.fineract.accounting.glaccount.data.GLAccountData;
 import org.apache.fineract.portfolio.loanproduct.data.LoanProductData;
 
+@Data
+@NoArgsConstructor
+@Accessors(chain = true)
 @SuppressWarnings("unused")
 public final class ProvisioningCriteriaData implements Comparable<ProvisioningCriteriaData>, Serializable {
 
-    private final Long criteriaId;
-    private final String criteriaName;
-    private final String createdBy;
-    private final Collection<LoanProductData> loanProducts;
+    private static final long serialVersionUID = 1L;
+
+    private Long criteriaId;
+    private String criteriaName;
+    private String createdBy;
+    private Collection<LoanProductData> loanProducts;
     private Collection<LoanProductData> selectedLoanProducts;
-    private final Collection<ProvisioningCriteriaDefinitionData> definitions;

Review Comment:
   @BLasan we are removing `final` keyword as we are introducing setters and `final` only makes sense for immutable classes. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org