You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by escowles <gi...@git.apache.org> on 2015/11/24 15:17:23 UTC
[GitHub] jena pull request: Fixing namespaceTTL (was recursively calling it...
GitHub user escowles opened a pull request:
https://github.com/apache/jena/pull/102
Fixing namespaceTTL (was recursively calling itself)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/escowles/jena namespace-ttl
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/102.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #102
----
commit e84522723a7f51f5862bc90a2b3ef9f130a94792
Author: Esmé Cowles <es...@ticklefish.org>
Date: 2015-11-24T14:15:21Z
Fixing namespaceTTL (was recursively calling itself)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: Fixing namespaceTTL (was recursively calling it...
Posted by escowles <gi...@git.apache.org>.
Github user escowles commented on the pull request:
https://github.com/apache/jena/pull/102#issuecomment-159313668
I think that the escaping is only needed for the localname -- the namespace URI will usually contain characters (`.-/#`) that would be improperly escaped by escape_PN_LOCAL_ESC().
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: Fixing namespaceTTL (was recursively calling it...
Posted by afs <gi...@git.apache.org>.
Github user afs commented on the pull request:
https://github.com/apache/jena/pull/102#issuecomment-159388784
@escowles is right - escaping is only allowed in the local part. Also, the return from `namespaceTTL` is a IRI, to go in `<...>`, not the prefix name that is written in output as a bare word.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: Fixing namespaceTTL (was recursively calling it...
Posted by rvesse <gi...@git.apache.org>.
Github user rvesse commented on the pull request:
https://github.com/apache/jena/pull/102#issuecomment-159310099
Thanks for the fix, applied to trunk
I notice the method definition looks a bit odd in general - @afs should `namespaceTTL()` have a similar definition to `localnameTTL()` where it first calls `namespace()` and then applies escaping?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] jena pull request: Fixing namespaceTTL (was recursively calling it...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/jena/pull/102
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---