You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/06 15:15:18 UTC

[GitHub] [airflow] XD-DENG opened a new issue #14115: Migrate inline JavaScript scripting to external files

XD-DENG opened a new issue #14115:
URL: https://github.com/apache/airflow/issues/14115


   <!--
   
   Welcome to Apache Airflow!  For a smooth issue process, try to answer the following questions.
   Don't worry if they're not all applicable; just try to include what you can :-)
   
   If you need to include code snippets or logs, please put them in fenced code
   blocks.  If they're super-long, please use the details tag like
   <details><summary>super-long log</summary> lots of stuff </details>
   
   Please delete these comment blocks before submitting the issue.
   
   -->
   
   **Description**
   
   Currently we have inline JavaScript scripting in templates like `airflow/www/templates/airflow/[dags/dag/gantt/tree/graph].html` etc. In these scripting, some practices are not optimal, like unused arguments, usage of undeclared variables, style issues, etc.
   
   **Use case / motivation**
   
   As briefly discussed in https://github.com/apache/airflow/pull/14019#discussion_r568761030, it's better to migrate these inline JavaScript scripting to external files.
   
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ryanahamilton commented on issue #14115: Migrate inline JavaScript scripting to external files

Posted by GitBox <gi...@apache.org>.
ryanahamilton commented on issue #14115:
URL: https://github.com/apache/airflow/issues/14115#issuecomment-775410632


   @bbovenzi that would be great—assigning to you!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bbovenzi commented on issue #14115: Migrate inline JavaScript scripting to external files

Posted by GitBox <gi...@apache.org>.
bbovenzi commented on issue #14115:
URL: https://github.com/apache/airflow/issues/14115#issuecomment-775399910


   I can take this one, if that's cool.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] XD-DENG commented on issue #14115: Migrate inline JavaScript scripting to external files

Posted by GitBox <gi...@apache.org>.
XD-DENG commented on issue #14115:
URL: https://github.com/apache/airflow/issues/14115#issuecomment-775411490


   Thanks @bbovenzi for your interest!
   
   If you would like to proceed, it would be great to share how you would plan to make this change, and potential issues you can foresee. I believe @ryanahamilton , our UI guru, already has some brief ideas about these, so it would be great to discuss together.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] XD-DENG commented on issue #14115: Migrate inline JavaScript scripting to external files

Posted by GitBox <gi...@apache.org>.
XD-DENG commented on issue #14115:
URL: https://github.com/apache/airflow/issues/14115#issuecomment-775412591


   Ha, I just see you guys are from the same team. This issue is in good handsđź‘Ť Tip-top!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bbovenzi closed issue #14115: Migrate inline JavaScript scripting to external files

Posted by GitBox <gi...@apache.org>.
bbovenzi closed issue #14115:
URL: https://github.com/apache/airflow/issues/14115


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org