[jira] [Commented] (HBASE-18420) Some methods of Admin don't use ColumnFamilyDescriptor

["Mike Drob (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-18420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16095370#comment-16095370 ] 

Mike Drob commented on HBASE-18420:
-----------------------------------

+1 assuming no QA issues.

How do we check for folks adding the wrong method signature going forward?

> Some methods of Admin don't use ColumnFamilyDescriptor
> ------------------------------------------------------
>
>                 Key: HBASE-18420
>                 URL: https://issues.apache.org/jira/browse/HBASE-18420
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>             Fix For: 3.0.0, 2.0.0-alpha-2
>
>         Attachments: HBASE-18420.v0.patch
>
>
> I overlooked them when committing HBASE-18241. 
> Admin class
> ||Removed API||New API||
> |modifyColumnFamily(TableName, HColumnDescriptor)|modifyColumnFamily(TableName, ColumnFamilyDescriptor)|
> |modifyColumnFamilyAsync(TableName, HColumnDescriptor)|modifyColumnFamilyAsync(TableName, ColumnFamilyDescriptor)|
> |addColumnFamily(TableName, HColumnDescriptor)|addColumnFamily(TableName, ColumnFamilyDescriptor)|
> |addColumnFamilyAsync(TableName, HColumnDescriptor)|addColumnFamilyAsync(TableName, ColumnFamilyDescriptor)|
> These methods are introduced by HBASE-16519 and HBASE-1989. Both of them belong to 2.0 so we can change the input arguments without worrying about any compatibility issue.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)