[GitHub] spark pull request: [SPARK-10618] [Mesos] Refactoring scheduling c...

[andrewor14 <gi...@git.apache.org>]

Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10326#discussion_r51498599
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala ---
    @@ -308,6 +303,23 @@ private[spark] class CoarseMesosSchedulerBackend(
         }
       }
     
    +    // ToDo: Abstract out each condition and log them.
    +  def isOfferSatisfiesRequirements(slaveId: String, mem: Double, cpusOffered: Int,
    +                                   sc: SparkContext): Boolean = {
    --- End diff --
    
    style:
    ```
    def offerSatisfiesRequirements(
        slaveId: String,
        mem: Double,
        cpusOffered: Int,
        sc: SparkContext): Boolean = {
      ...
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org