You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/12/07 18:46:06 UTC

[GitHub] [geode] kirklund commented on a change in pull request #7164: GEODE-9831: support SISMEMBER support command

kirklund commented on a change in pull request #7164:
URL: https://github.com/apache/geode/pull/7164#discussion_r764271330



##########
File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/commands/RedisCommandType.java
##########
@@ -242,6 +242,7 @@
   SADD(new SAddExecutor(), SUPPORTED, new Parameter().min(3).flags(WRITE, DENYOOM, FAST)),
   SDIFF(new SDiffExecutor(), SUPPORTED,
       new Parameter().min(2).lastKey(-1).flags(READONLY, SORT_FOR_SCRIPT)),
+  SISMEMBER(new SIsMemberExecutor(), SUPPORTED, new Parameter().exact(3).flags(READONLY, FAST)),

Review comment:
       I'd recommend writing a simple unit test for RedisCommandType. It would just confirm that SISMEMBER is supported and maybe has an SIsMemberExecutor and 3 parameters including the READONLY and FAST flags.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org