You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2018/09/04 18:51:34 UTC

[Bug 62674] New: org.apache.jasper.JspC no longer compiles

https://bz.apache.org/bugzilla/show_bug.cgi?id=62674

            Bug ID: 62674
           Summary: org.apache.jasper.JspC no longer compiles
           Product: Tomcat 8
           Version: 8.5.33
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: blocker
          Priority: P2
         Component: Jasper
          Assignee: dev@tomcat.apache.org
          Reporter: paul@postconf.com
  Target Milestone: ----

The update from 8.5.32 to 8.5.33 has caused org.apache.jasper.JspC to fail. 
Symptom is that it hangs forever.  Ant output for 8.5.33:

     [java] Sep 02, 2018 9:36:19 AM org.apache.jasper.servlet.TldScanner
scanJars
     [java] INFO: At least one JAR was scanned for TLDs yet contained no TLDs.
Enable debug logging for this logger for a complete list of JARs that were
scanned but no TLDs were found in them. Skipping unneeded JARs during scanning
can improve startup time and JSP compilation time.
     [java] Sep 02, 2018 9:36:19 AM org.apache.jasper.JspC execute
     [java] INFO: Generation completed with [0] errors in [616] milliseconds

vs 8.5.32:

     [java] Sep 02, 2018 12:27:17 PM org.apache.jasper.servlet.TldScanner
scanJars
     [java] INFO: At least one JAR was scanned for TLDs yet contained no TLDs.
Enable debug logging for this logger for a
complete list of JARs that were scanned but no TLDs were found in them.
Skipping unneeded JARs during scanning can improve
startup time and JSP compilation time.
    [javac] Compiling 68 source files to .../build/classes
     [xslt] Processing .../src/conf/web.xml to .../build/web.xml
     [xslt] Loading stylesheet .../src/webmerge.xsl

Neither debug flags nor strace illustrate the issue. Symptoms are identical
across Ubuntu 16.04, 18.04 and FreeBSD 11.2 hosts running java 1.8.0_181 with
plenty of disk and ram.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 62674] org.apache.jasper.JspC no longer compiles

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62674

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #14 from Mark Thomas <ma...@apache.org> ---
Assuming these reports are all for a single bug (which I think is the case but
comment #2 makes me slightly unsure)...

Fixed in:
- trunk for 9.0.13 onwards
- 8.5.x for 8.5.35 onwards
- 7.0.x for 7.0.92 onwards

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 62674] org.apache.jasper.JspC no longer compiles

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62674

--- Comment #6 from Paul <pa...@postconf.com> ---
Created attachment 36147
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36147&action=edit
output of 'strace ant'

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 62674] org.apache.jasper.JspC no longer compiles

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62674

--- Comment #9 from Masayuki Hatta <mh...@mhatta.org> ---
I'm pretty sure it's involved with the following bugs.

https://bz.apache.org/bugzilla/show_bug.cgi?id=53492

https://bz.apache.org/bugzilla/show_bug.cgi?id=62662

Possibly the fix in #62662 was not enough?

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 62674] org.apache.jasper.JspC no longer compiles

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62674

--- Comment #10 from Mark Thomas <ma...@apache.org> ---
(In reply to Paul from comment #6)
> Created attachment 36147 [details]
> output of 'strace ant'

That isn't what Chris asked for. Please provide a Java thread dump.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 62674] org.apache.jasper.JspC no longer compiles

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62674

--- Comment #7 from Paul <pa...@postconf.com> ---
Created attachment 36148
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36148&action=edit
output of 'ant -d'

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 62674] org.apache.jasper.JspC no longer compiles

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62674

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDINFO

--- Comment #1 from Mark Thomas <ma...@apache.org> ---
jspc works for me with a simple test case.

Please provide the simplest possible JSP (or set of JSPs and/or tags) that
fails to compile.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 62674] org.apache.jasper.JspC no longer compiles

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62674

--- Comment #4 from Christopher Schultz <ch...@christopherschultz.net> ---
Can you post a thread-dump of JspC when it's "hung"? That might shed some light
on the situation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 62674] org.apache.jasper.JspC no longer compiles

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62674

Paul <pa...@postconf.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|REOPENED                    |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 62674] org.apache.jasper.JspC no longer compiles

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62674

Masayuki Hatta <mh...@mhatta.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mhatta@mhatta.org
             Status|NEEDINFO                    |NEW

--- Comment #8 from Masayuki Hatta <mh...@mhatta.org> ---
Hi,

The same problem was reported to Debian.

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=908884

I could reproduce this hung up with Debian-packaged libtomcat8-java 8.5.33-1
and 8.5.34-1.  Installing libtomcat8-java 8.5.32-2 fixes this.  The original
reporter also said that he could reproduce the problem on Ubuntu and FreeBSD,
so I guess some bug must be entered in the upstream JSP handling between
Tomcat8 8.5.32 and 8.5.33.

Please let me know if I could help anything else.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 62674] org.apache.jasper.JspC no longer compiles

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62674

--- Comment #3 from Paul <pa...@postconf.com> ---
Also hangs in 8.5.34.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 62674] org.apache.jasper.JspC no longer compiles

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62674

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|blocker                     |major

--- Comment #5 from Mark Thomas <ma...@apache.org> ---
Dropping severity back to default. This isn't going to block a release.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 62674] org.apache.jasper.JspC no longer compiles

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62674

--- Comment #11 from Masayuki Hatta <mh...@mhatta.org> ---
I2P's analysis and workaround for this problem:

https://trac.i2p2.de/ticket/2307#comment:1

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 62674] org.apache.jasper.JspC no longer compiles

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62674

--- Comment #2 from Paul <pa...@postconf.com> ---
Have not (yet) isolated a specific file among the 120+ jsps, taglibs and
fragments but it does seem to be related to either the number of files to be
compiled or some element common to a subset of jsps.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 62674] org.apache.jasper.JspC no longer compiles

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62674

--- Comment #13 from Mark Thomas <ma...@apache.org> ---
Progress. If JspC is called directly using the Java task (rather than using the
Ant Jasper task) and fork is set to true for the Java task then the hand will
be observed.

That it is necessary to use the Java task rather than the Jasper task looks to
be the most likely explanation of the differences between the reported
behaviour in comment #2 and comment #11.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 62674] org.apache.jasper.JspC no longer compiles

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62674

Paul <pa...@postconf.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
             Status|RESOLVED                    |REOPENED

--- Comment #15 from Paul <pa...@postconf.com> ---
Behavior still occurs in 8.5.34.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 62674] org.apache.jasper.JspC no longer compiles

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62674

--- Comment #12 from Mark Thomas <ma...@apache.org> ---
The relevant information is:

<quote>
... with new the multithreaded JspC implementation in Tomcat 8.5.33, invoking
it from an ant script as we do (with fork=true), the JVM never exits,
presumably because the Tomcat thread pool is not marked as daemon.
</quote>

It should be fairly easy to confirm that this is the issue. What is puzzling is
that I'd expect this to fail even with a few - or even one - JSPs but comment
#2 suggests that that was not the case.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org