You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/11/09 07:13:00 UTC
[jira] [Commented] (FLINK-10835) Remove duplicated Round-robin
ChannelSelector implementation in RecordWriterTest
[ https://issues.apache.org/jira/browse/FLINK-10835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680973#comment-16680973 ]
ASF GitHub Bot commented on FLINK-10835:
----------------------------------------
zhijiangW opened a new pull request #7069: [FLINK-10835][network] Remove duplicated round-robin ChannelSelector implementation
URL: https://github.com/apache/flink/pull/7069
## What is the purpose of the change
*`RoundRobinChannelSelector` exists for default selector in RecordWriter mainly for tests. Another similar `RoundRobin` implementation exists in `RecordWriterTest`, only because the difference in starting channel index for round-robin.*
*We can adjust the test verify logic to keep the same behavior with `RoundRobinChannelSelector`, and then remove the duplicated `RoundRobin`.*
## Brief change log
- *Remove `RoundRobin` in `RecordWriterTest`*
- *Simplify the implementation for `RoundRobinChannelSelector`*
## Verifying this change
*This change is already covered by existing tests.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Remove duplicated Round-robin ChannelSelector implementation in RecordWriterTest
> --------------------------------------------------------------------------------
>
> Key: FLINK-10835
> URL: https://issues.apache.org/jira/browse/FLINK-10835
> Project: Flink
> Issue Type: Sub-task
> Components: Network
> Affects Versions: 1.8.0
> Reporter: zhijiang
> Assignee: zhijiang
> Priority: Minor
> Labels: pull-request-available
>
> {{RoundRobinChannelSelector}} exists for default selector in {{RecordWriter}} mainly for tests. Another similar {{RoundRobin}} implementation exists in {{RecordWriterTest}}, only because the difference in starting channel index for round-robin.
> We can adjust the test verify logic to keep the same behavior with {{RoundRobinChannelSelector}}, and then remove the duplicated {{RoundRobin}}.
> It can make simple in following work [FLINK-10622|https://issues.apache.org/jira/browse/FLINK-10662]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)