[GitHub] lebeg commented on a change in pull request #11053: [MXNET-244] Fixed armv7 wheel

[GitBox <gi...@apache.org>]

lebeg commented on a change in pull request #11053: [MXNET-244] Fixed armv7 wheel
URL: https://github.com/apache/incubator-mxnet/pull/11053#discussion_r191235181
 
 

 ##########
 File path: ci/docker/runtime_functions.sh
 ##########
 @@ -83,31 +102,40 @@ build_armv6() {
         -DBUILD_CPP_EXAMPLES=OFF \
         -Dmxnet_LINKER_LIBS=-lgfortran \
         -G Ninja /work/mxnet
+
     ninja
-    export MXNET_LIBRARY_PATH=`pwd`/libmxnet.so
-    cd /work/mxnet/python
-    python setup.py bdist_wheel --universal
-    cp dist/*.whl /work/build
+    build_wheel
+
     popd
 }
 
 build_armv7() {
     set -ex
     pushd .
     cd /work/build
-    cmake\
-        -DUSE_CUDA=OFF\
-        -DUSE_OPENCV=OFF\
-        -DUSE_OPENMP=OFF\
-        -DUSE_SIGNAL_HANDLER=ON\
-        -DCMAKE_BUILD_TYPE=RelWithDebInfo\
-        -DUSE_MKL_IF_AVAILABLE=OFF\
+
+    # Lapack functionality will be included and statically linked to openblas.
 
 Review comment:
   As I've said already, it is not a trivial task and can take up significant time and effort with functionality change impacting multiple builds. This PR is about fixing the ARMv7 build, for now without improvements. It is a big comment and only a few lines to keep in sync, so that it can be considered as tolerated evil. There is already a ticket to track the work on the problem: [MXNET-115](https://issues.apache.org/jira/browse/MXNET-115)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services