You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/09/03 23:49:41 UTC

[GitHub] [helix] kaisun2000 commented on a change in pull request #1348: Enable build command to compile tests

kaisun2000 commented on a change in pull request #1348:
URL: https://github.com/apache/helix/pull/1348#discussion_r483311046



##########
File path: build
##########
@@ -19,4 +19,4 @@
 # under the License.
 #
 
-mvn clean install -Dmaven.test.skip=true
+mvn clean install -Dmaven.test.skip.exec=true

Review comment:
       maven.test.skip.exec means compile and not executed, while previously it does not even compile. That is my understanding. 
   
   What is the issue previously?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org