[jira] [Commented] (NIFI-745) Disabling Controller Service stuck

["Mark Payne (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612108#comment-14612108 ] 

Mark Payne commented on NIFI-745:
---------------------------------

[~mcgilman] is the suggestion here to change the behavior, so that if a method annotated with @OnDisable throws an Exception, we just log it and move on?

I like that approach. I don't know why in the world I wrote it such that it will continually retry. It should certainly behave the same as Processors do with their @OnStopped / @OnUnscheduled. They are notified of the lifecycle event and given a chance to handle it. Then we move on, regardless of whether or not the method succeeds.

> Disabling Controller Service stuck
> ----------------------------------
>
>                 Key: NIFI-745
>                 URL: https://issues.apache.org/jira/browse/NIFI-745
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>            Reporter: Matt Gilman
>             Fix For: 0.2.0
>
>
> Per the nifi-api a controller service OnDisable method will be invoked when the user disables that service. If that method fails with an exception it will be retried a short time later. This will continue until it successfully completes.
> Unfortunately, this means that if services continually throws an exception during OnDisable the user will not be able to do anything with the service. This is because controller services need to be Disabled in order to support editing its configuration or attempting to Enable. The service in question will not transition to the Disabled state until its OnDisable completes without issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)