[jira] [Commented] (CASSANDRA-11960) Hints are not seekable

["Branimir Lambov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-11960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399102#comment-15399102 ] 

Branimir Lambov commented on CASSANDRA-11960:
---------------------------------------------

I pushed an update to your branch [here|https://github.com/blambov/cassandra/tree/spodkowinski/WIP-11960] which replaces the single {{long}} position we stored with a mark object that includes compressed and uncompressed positions and can be used to seek quickly and accurately. This should be able to solve the problem for all hint file variations (plain, compressed, encrypted); we must test all of them though.

I tried to go back to the old code in {{HintsDispatcher}} but had to turn off {{RETRY}} to make the tests work. I must admit I haven't yet looked closely at all the changes you made and don't understand why this should be necessary.


> Hints are not seekable
> ----------------------
>
>                 Key: CASSANDRA-11960
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-11960
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: Robert Stupp
>            Assignee: Stefan Podkowinski
>
> Got the following error message on trunk. No idea how to reproduce. But the only thing the (not overridden) seek method does is throwing this exception.
> {code}
> ERROR [HintsDispatcher:2] 2016-06-05 18:51:09,397 CassandraDaemon.java:222 - Exception in thread Thread[HintsDispatcher:2,1,main]
> java.lang.UnsupportedOperationException: Hints are not seekable.
> 	at org.apache.cassandra.hints.HintsReader.seek(HintsReader.java:114) ~[main/:na]
> 	at org.apache.cassandra.hints.HintsDispatcher.seek(HintsDispatcher.java:79) ~[main/:na]
> 	at org.apache.cassandra.hints.HintsDispatchExecutor$DispatchHintsTask.deliver(HintsDispatchExecutor.java:257) ~[main/:na]
> 	at org.apache.cassandra.hints.HintsDispatchExecutor$DispatchHintsTask.dispatch(HintsDispatchExecutor.java:242) ~[main/:na]
> 	at org.apache.cassandra.hints.HintsDispatchExecutor$DispatchHintsTask.dispatch(HintsDispatchExecutor.java:220) ~[main/:na]
> 	at org.apache.cassandra.hints.HintsDispatchExecutor$DispatchHintsTask.run(HintsDispatchExecutor.java:199) ~[main/:na]
> 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[na:1.8.0_91]
> 	at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[na:1.8.0_91]
> 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) ~[na:1.8.0_91]
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) [na:1.8.0_91]
> 	at java.lang.Thread.run(Thread.java:745) [na:1.8.0_91]
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)