You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "MarcoGorelli (via GitHub)" <gi...@apache.org> on 2023/02/19 09:53:28 UTC

[GitHub] [arrow] MarcoGorelli commented on a diff in pull request #14662: GH-31905: [DevTools] Add linting to Cython files

MarcoGorelli commented on code in PR #14662:
URL: https://github.com/apache/arrow/pull/14662#discussion_r1111203864


##########
.pre-commit-config.yaml:
##########
@@ -47,3 +47,8 @@ repos:
           - python
         exclude: vendored
         args: [--config, python/setup.cfg]
+  - repo: https://github.com/MarcoGorelli/cython-lint
+    rev: v0.12.4
+    hooks:
+      - id: cython-lint
+        args: [--max-line-length=120]

Review Comment:
   Thanks for your review
   
   It was just to keep the diff down until there was some agreement on whether you wanted this
   
   If you're on board with it, I can go ahead and reduce it to 88



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org