You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/03 00:29:00 UTC
[GitHub] [airflow] kaxil opened a new pull request #15169: Replace new url for Stable Airflow Docs
kaxil opened a new pull request #15169:
URL: https://github.com/apache/airflow/pull/15169
`https://airflow.apache.org/docs/stable/` -> `https://airflow.apache.org/docs/apache-airflow/stable`
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #15169: Replace new url for Stable Airflow Docs
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #15169:
URL: https://github.com/apache/airflow/pull/15169#discussion_r606791619
##########
File path: docs/apache-airflow-providers-microsoft-azure/operators/azure_blob_to_gcs.rst
##########
@@ -31,7 +31,7 @@ Please follow Azure
to do it.
TOKEN should be added to the Connection in Airflow in JSON format, Login and Password as plain text.
-You can check `how to do such connection <https://airflow.apache.org/docs/stable/howto/connection/index.html#editing-a-connection-with-the-ui>`_.
+You can check `how to do such connection <https://airflow.apache.org/docs/apache-airflow/stable/howto/connection/index.html#editing-a-connection-with-the-ui>`_.
Review comment:
Actually we can't do this as the reference is in core doc and provider is built separatly, hence doc-build errors with reference not found
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15169: Replace new url for Stable Airflow Docs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15169:
URL: https://github.com/apache/airflow/pull/15169#issuecomment-812779146
[The Workflow run](https://github.com/apache/airflow/actions/runs/713286074) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15169: Replace new url for Stable Airflow Docs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15169:
URL: https://github.com/apache/airflow/pull/15169#issuecomment-813018265
[The Workflow run](https://github.com/apache/airflow/actions/runs/716517828) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15169: Replace new url for Stable Airflow Docs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15169:
URL: https://github.com/apache/airflow/pull/15169#issuecomment-813021615
[The Workflow run](https://github.com/apache/airflow/actions/runs/716556163) is cancelling this PR. Building images for the PR has failed. Follow the workflow link to check the reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15169: Replace new url for Stable Airflow Docs
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15169:
URL: https://github.com/apache/airflow/pull/15169#issuecomment-813024487
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil closed pull request #15169: Replace new url for Stable Airflow Docs
Posted by GitBox <gi...@apache.org>.
kaxil closed pull request #15169:
URL: https://github.com/apache/airflow/pull/15169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #15169: Replace new url for Stable Airflow Docs
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #15169:
URL: https://github.com/apache/airflow/pull/15169
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #15169: Replace new url for Stable Airflow Docs
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #15169:
URL: https://github.com/apache/airflow/pull/15169#discussion_r606543708
##########
File path: docs/apache-airflow-providers-microsoft-azure/operators/azure_blob_to_gcs.rst
##########
@@ -31,7 +31,7 @@ Please follow Azure
to do it.
TOKEN should be added to the Connection in Airflow in JSON format, Login and Password as plain text.
-You can check `how to do such connection <https://airflow.apache.org/docs/stable/howto/connection/index.html#editing-a-connection-with-the-ui>`_.
+You can check `how to do such connection <https://airflow.apache.org/docs/apache-airflow/stable/howto/connection/index.html#editing-a-connection-with-the-ui>`_.
Review comment:
This should be internal link as it refers to another `rst` file
```suggestion
You can check :ref:`how to do such connection <howto/connection:editing-a-connection-with-the-ui>`
```
hope i got the syntax right. It's late :)
Used this [example](https://github.com/apache/airflow/blob/master/docs/apache-airflow/production-deployment.rst#impersonate-service-accounts)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org