You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Sandish Kumar HN (Code Review)" <ge...@cloudera.org> on 2019/06/13 20:59:45 UTC
[kudu-CR] Testing helm charts
Sandish Kumar HN has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13641
Change subject: Testing helm charts
......................................................................
Testing helm charts
Change-Id: I0b9c2a8f4042cf603b7d1aa54cc21bde9b59c975
---
M kubernetes/helm/README.adoc
M kubernetes/helm/kudu/Chart.yaml
2 files changed, 13 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/13641/1
--
To view, visit http://gerrit.cloudera.org:8080/13641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0b9c2a8f4042cf603b7d1aa54cc21bde9b59c975
Gerrit-Change-Number: 13641
Gerrit-PatchSet: 1
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
[kudu-CR] [k8s] Improve helm chart testing
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13641 )
Change subject: [k8s] Improve helm chart testing
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b9c2a8f4042cf603b7d1aa54cc21bde9b59c975
Gerrit-Change-Number: 13641
Gerrit-PatchSet: 3
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Comment-Date: Fri, 14 Jun 2019 17:16:15 +0000
Gerrit-HasComments: No
[kudu-CR] Testing helm charts,
Posted by "Sandish Kumar HN (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13641
to look at the new patch set (#2).
Change subject: Testing helm charts,
......................................................................
Testing helm charts,
helm template : rendering helm templates
helm lint: examines a chart for possible issues,
useful to validate chart dependencies.
helm test: To run heml chart tests
Change-Id: I0b9c2a8f4042cf603b7d1aa54cc21bde9b59c975
---
M kubernetes/helm/README.adoc
M kubernetes/helm/kudu/Chart.yaml
2 files changed, 13 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/13641/2
--
To view, visit http://gerrit.cloudera.org:8080/13641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0b9c2a8f4042cf603b7d1aa54cc21bde9b59c975
Gerrit-Change-Number: 13641
Gerrit-PatchSet: 2
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [k8s] Improve helm chart testing
Posted by "Sandish Kumar HN (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13641
to look at the new patch set (#3).
Change subject: [k8s] Improve helm chart testing
......................................................................
[k8s] Improve helm chart testing
Adds documentation for helm chart testing and linting.
Change-Id: I0b9c2a8f4042cf603b7d1aa54cc21bde9b59c975
---
M kubernetes/helm/README.adoc
M kubernetes/helm/kudu/Chart.yaml
2 files changed, 13 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/13641/3
--
To view, visit http://gerrit.cloudera.org:8080/13641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0b9c2a8f4042cf603b7d1aa54cc21bde9b59c975
Gerrit-Change-Number: 13641
Gerrit-PatchSet: 3
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [k8s] Improve helm chart testing
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13641 )
Change subject: [k8s] Improve helm chart testing
......................................................................
[k8s] Improve helm chart testing
Adds documentation for helm chart testing and linting.
Change-Id: I0b9c2a8f4042cf603b7d1aa54cc21bde9b59c975
Reviewed-on: http://gerrit.cloudera.org:8080/13641
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
---
M kubernetes/helm/README.adoc
M kubernetes/helm/kudu/Chart.yaml
2 files changed, 13 insertions(+), 2 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0b9c2a8f4042cf603b7d1aa54cc21bde9b59c975
Gerrit-Change-Number: 13641
Gerrit-PatchSet: 4
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sandish Kumar HN <sa...@gmail.com>
[kudu-CR] Testing helm charts,
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13641 )
Change subject: Testing helm charts,
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13641/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13641/2//COMMIT_MSG@7
PS2, Line 7: Testing helm charts,
Can you update this to be more descriptive? Something like:
[k8s] Improve helm chart testing
Adds documentation for helm chart testing and linting.
http://gerrit.cloudera.org:8080/#/c/13641/2/kubernetes/helm/kudu/Chart.yaml
File kubernetes/helm/kudu/Chart.yaml:
http://gerrit.cloudera.org:8080/#/c/13641/2/kubernetes/helm/kudu/Chart.yaml@23
PS2, Line 23: version: 1.0
Why did you change the version?
--
To view, visit http://gerrit.cloudera.org:8080/13641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b9c2a8f4042cf603b7d1aa54cc21bde9b59c975
Gerrit-Change-Number: 13641
Gerrit-PatchSet: 2
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 14 Jun 2019 17:03:52 +0000
Gerrit-HasComments: Yes
[kudu-CR] [k8s] Improve helm chart testing
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13641 )
Change subject: [k8s] Improve helm chart testing
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b9c2a8f4042cf603b7d1aa54cc21bde9b59c975
Gerrit-Change-Number: 13641
Gerrit-PatchSet: 3
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Comment-Date: Fri, 14 Jun 2019 17:16:06 +0000
Gerrit-HasComments: No
[kudu-CR] [k8s] Improve helm chart testing
Posted by "Sandish Kumar HN (Code Review)" <ge...@cloudera.org>.
Sandish Kumar HN has posted comments on this change. ( http://gerrit.cloudera.org:8080/13641 )
Change subject: [k8s] Improve helm chart testing
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13641/2/kubernetes/helm/kudu/Chart.yaml
File kubernetes/helm/kudu/Chart.yaml:
http://gerrit.cloudera.org:8080/#/c/13641/2/kubernetes/helm/kudu/Chart.yaml@23
PS2, Line 23: version: 1.0
> Gotcha, okay we should get this fix into the release then.
okay
--
To view, visit http://gerrit.cloudera.org:8080/13641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b9c2a8f4042cf603b7d1aa54cc21bde9b59c975
Gerrit-Change-Number: 13641
Gerrit-PatchSet: 3
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Comment-Date: Fri, 14 Jun 2019 17:14:59 +0000
Gerrit-HasComments: Yes
[kudu-CR] [k8s] Improve helm chart testing
Posted by "Sandish Kumar HN (Code Review)" <ge...@cloudera.org>.
Sandish Kumar HN has posted comments on this change. ( http://gerrit.cloudera.org:8080/13641 )
Change subject: [k8s] Improve helm chart testing
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13641/2/kubernetes/helm/kudu/Chart.yaml
File kubernetes/helm/kudu/Chart.yaml:
http://gerrit.cloudera.org:8080/#/c/13641/2/kubernetes/helm/kudu/Chart.yaml@23
PS2, Line 23: version: 1.0
> Why did you change the version?
It only takes SemVer, no strings. got validation error with helm lint for using "latest" as version.
--
To view, visit http://gerrit.cloudera.org:8080/13641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b9c2a8f4042cf603b7d1aa54cc21bde9b59c975
Gerrit-Change-Number: 13641
Gerrit-PatchSet: 3
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Comment-Date: Fri, 14 Jun 2019 17:07:21 +0000
Gerrit-HasComments: Yes
[kudu-CR] [k8s] Improve helm chart testing
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13641 )
Change subject: [k8s] Improve helm chart testing
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13641/2/kubernetes/helm/kudu/Chart.yaml
File kubernetes/helm/kudu/Chart.yaml:
http://gerrit.cloudera.org:8080/#/c/13641/2/kubernetes/helm/kudu/Chart.yaml@23
PS2, Line 23: version: 1.0
> It only takes SemVer, no strings. got validation error with helm lint for u
Gotcha, okay we should get this fix into the release then.
--
To view, visit http://gerrit.cloudera.org:8080/13641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b9c2a8f4042cf603b7d1aa54cc21bde9b59c975
Gerrit-Change-Number: 13641
Gerrit-PatchSet: 2
Gerrit-Owner: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Sandish Kumar HN <sa...@gmail.com>
Gerrit-Comment-Date: Fri, 14 Jun 2019 17:13:12 +0000
Gerrit-HasComments: Yes