You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/15 11:00:43 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #2917: Fix release verification script by not overriding `ARROW_TEST_DATA` or `PARQUET_TEST_DATA`
alamb opened a new pull request, #2917:
URL: https://github.com/apache/arrow-datafusion/pull/2917
# Which issue does this PR close?
Fixes https://github.com/apache/arrow-datafusion/issues/2916
Fixes https://github.com/apache/arrow-datafusion/issues/2719
# Rationale for this change
Some people have been seeing the `verify_release_candidate.sh` script fail when verifying arrow releases. The failures are due to paths into the "testing data" which are not properly normalized
# What changes are included in this PR?
Note here is an example of the contents that are in the tarball (note the presence of `testing` and `parquet-testing`):
```shell
ls /var/folders/s3/h5hgj43j0bv83shtmz_t_w400000gn/T/arrow-10.0.0.XXXXX.s39Dslgg/apache-arrow-datafusion-10.0.0
CHANGELOG.md README.md dev/ rustfmt.toml
CODE_OF_CONDUCT.md benchmarks/ docs/ target/
CONTRIBUTING.md ci/ header test-rustup/
Cargo.lock conbench/ integration-tests/ testing/
Cargo.toml datafusion/ parquet-testing/
LICENSE.txt datafusion-cli/ pre-commit.sh*
NOTICE.txt datafusion-examples/ python/
```
# Are there any user-facing changes?
Hopefully the verify script works on subsequent releases
# Testing
Note that I don't
```shell
(arrow_dev) alamb@MacBook-Pro-8:~/Software/arrow-datafusion$ env | grep ARROW_TEST_DATA
(arrow_dev) alamb@MacBook-Pro-8:~/Software/arrow-datafusion$ env | grep PARQUET_TEST_DATA
```
Prior to this change, running:
```shell
./dev/release/verify-release-candidate.sh 10.0.0 1
```
Would fail for me locally (with the same diff reported by @nevi-me in https://github.com/apache/arrow-datafusion/issues/2916)
afterwards it passes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #2917: Fix release verification script by not overriding `ARROW_TEST_DATA` or `PARQUET_TEST_DATA`
Posted by GitBox <gi...@apache.org>.
alamb merged PR #2917:
URL: https://github.com/apache/arrow-datafusion/pull/2917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #2917: Fix release verification script by not overriding `ARROW_TEST_DATA` or `PARQUET_TEST_DATA`
Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #2917:
URL: https://github.com/apache/arrow-datafusion/pull/2917#issuecomment-1185667813
> @andygrove I don't normally have `ARROW_TEST_DATA` set. If you do, would you mind running `./dev/release/verify-release-candidate.sh 10.0.0 1` from this branch to make sure it works for you?
Yes, works fine for me, with these env vars set:
```
$ env | grep TEST_DATA
ARROW_TEST_DATA=/home/andy/git/apache/arrow-datafusion/testing/data
PARQUET_TEST_DATA=/home/andy/git/apache/arrow-datafusion/parquet-testing/data
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #2917: Fix release verification script by not overriding `ARROW_TEST_DATA` or `PARQUET_TEST_DATA`
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2917:
URL: https://github.com/apache/arrow-datafusion/pull/2917#issuecomment-1186157511
Benchmark runs are scheduled for baseline = fe1995f31164774776baf67f6fb26ba66c42db0b and contender = d0496b01a78d8f876898b401ea7cda4ee31bfa40. d0496b01a78d8f876898b401ea7cda4ee31bfa40 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/ac49f58c079e4fcdbac17564bf503fea...c4cccbd8b2aa44d29a02cee299415332/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/d892eb692d344b069fc6a332c3016fc1...3b26cf252caa43ad88b27919a741f4d8/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/fd365dbeab6849ee954d0e4a21b9de77...122652d1cc3745d69db0b05559fc4d9d/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/8cfe50ab5a594277bed05fc042ddba28...cbb55f187998419898d432352eb1f8f6/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #2917: Fix release verification script by not overriding `ARROW_TEST_DATA` or `PARQUET_TEST_DATA`
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2917:
URL: https://github.com/apache/arrow-datafusion/pull/2917#issuecomment-1185436080
@andygrove I don't normally have `ARROW_TEST_DATA` set. If you do, would you mind running `./dev/release/verify-release-candidate.sh 10.0.0 1` from this branch to make sure it works for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org