[jira] [Updated] (BOOKKEEPER-797) IllegalArgumentException when calling CodahaleOpStatsLogger#toOpStatsData()

["Matthieu Morel (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BOOKKEEPER-797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matthieu Morel updated BOOKKEEPER-797:
--------------------------------------
    Attachment: codahale-stats-opstats-fix.patch

Patch with test, generated using git diff --no-prefix

> IllegalArgumentException when calling CodahaleOpStatsLogger#toOpStatsData()
> ---------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-797
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-797
>             Project: Bookkeeper
>          Issue Type: Bug
>          Components: bookkeeper-stats
>    Affects Versions: 4.3.0
>            Reporter: Matthieu Morel
>            Priority: Minor
>         Attachments: codahale-stats-opstats-fix.patch
>
>
> The implementation of CodahaleOpStatsLogger#toOpStatsData() passes incorrect parameters to codahale's Snapshot#getValue method, resulting in the following runtime exception:
> java.lang.IllegalArgumentException: 10.0 is not in [0..1]
> 	at com.codahale.metrics.Snapshot.getValue(Snapshot.java:52)
> 	at org.apache.bookkeeper.stats.CodahaleOpStatsLogger.toOpStatsData(CodahaleOpStatsLogger.java:64)
> ...
> In order to pass quantiles as [0..1] values, as expected by codahale metrics library, we must divide parameters by 100 before passing them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)