[jira] [Commented] (CLOUDSTACK-9830) QuotaAlertManagerTest fails testGetDifferenceDays on day before DST change

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-9830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15906387#comment-15906387 ] 

ASF GitHub Bot commented on CLOUDSTACK-9830:
--------------------------------------------

GitHub user nathanejohnson opened a pull request:

    https://github.com/apache/cloudstack/pull/2001

    CLOUDSTACK-9830 Fix DST bug in QuotaAlertManagerTest

    Replace the use of joda with Calendar, set explicitly to UTC when
    doing date manipulation.
    
    This fixes an issue where when running this test on a machine set to a local timezone that is about to switch to DST, the difference returns 0 versus 1.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/myENA/cloudstack CLOUDSTACK-9830

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/2001.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2001
    
----
commit 58877ecac2db7c1601c354d219777d394a316abf
Author: Nathan Johnson <nj...@ena.com>
Date:   2017-03-12T01:17:22Z

    CLOUDSTACK-9830 Fix DST bug in QuotaAlertManagerTest
    
    Replace the use of joda with Calendar, set explicitly to UTC when
    doing date manipulation.

----


> QuotaAlertManagerTest fails testGetDifferenceDays on day before DST change
> --------------------------------------------------------------------------
>
>                 Key: CLOUDSTACK-9830
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9830
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>         Environment: master
>            Reporter: Nathan Johnson
>            Assignee: Nathan Johnson
>            Priority: Minor
>
> this line (182 as of right now):
>     assertTrue(QuotaAlertManagerImpl.getDifferenceDays(now, new DateTime(now).plusDays(1).toDate()) == 1L);
> fails on days where we're about to "spring forward" and lose an hour.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)