You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/05/15 00:41:02 UTC

[GitHub] [beam] lostluck commented on pull request #11665: [BEAM-9951] Creating a synthetic source for the Go SDK.

lostluck commented on pull request #11665:
URL: https://github.com/apache/beam/pull/11665#issuecomment-628958995


   I think this LGTM.
   Overall, it's probably fine either way. In terms of effort, the risk is often "the pipelines emit nothing/very little" and terminate very quickly, which other metrics that expect certain amounts of data. The main risk is the user doesn't have validation on the profiling pipeline and think things are going very very fast. But given performance metrics tend to be "per element", they'll pay attention to things like that.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org