[GitHub] [spark] attilapiros commented on a change in pull request #24030: [SPARK-27109][SQL] Refactoring of TimestampFormatter and DateFormatter

[GitBox <gi...@apache.org>]

attilapiros commented on a change in pull request #24030: [SPARK-27109][SQL] Refactoring of TimestampFormatter and DateFormatter
URL: https://github.com/apache/spark/pull/24030#discussion_r264153941
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
 ##########
 @@ -61,6 +63,8 @@ private object DateTimeFormatterHelper {
   val cache = CacheBuilder.newBuilder()
     .maximumSize(128)
     .build[(String, Locale), DateTimeFormatter]()
+  // Sets hours, minutes, seconds and nanos of second to zeros
+  val zeroLocalTime = LocalTime.ofNanoOfDay(0)
 
 Review comment:
   You can use the existing LocalTime.MIN (or LocalTime.MIDNIGHT) constants.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org