You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/03/26 10:30:28 UTC

[GitHub] [netbeans] junichi11 opened a new pull request #3872: [NETBEANS-5599] PHP 8.1 Support: Pure intersection types

junichi11 opened a new pull request #3872:
URL: https://github.com/apache/netbeans/pull/3872


   - https://issues.apache.org/jira/browse/NETBEANS-5599
   - RFC: https://wiki.php.net/rfc/pure-intersection-types
   
   Part 3:
   - Fix the code completion feature
   
   Part 4:
   - Fix `ImplementAbstractMethodsHintError`, `InitializeFieldSuggestion`, and `UnusableTypesHintError`
   
   ![nb-php81-pure-intersection-types-hint1](https://user-images.githubusercontent.com/738383/160235350-9f5ba572-dbea-4058-86e1-8e73a6346964.png)
   
   ![nb-php81-pure-intersection-types-hint2](https://user-images.githubusercontent.com/738383/160235430-e6b9b8b5-d14c-4837-93d8-bd85ad1a9f37.png)
   
   
   Part 5:
   - Fix code generation features (generate getter, setter, constructor, override/implement methods)
   - Fix the `PhpCommentGenerator`
   
   Part 6:
   - Fix the `DocRenderer` to show intersection types
   - `mixed` type means special one of the union types since PHP 8.0,
   so show the type names as it is if the type name is a union type or an intersection type
   - Add the `truncate` method to the `StringUtils` to avoid showing long type names as it is
   
   ![nb-php81-pure-intersection-types-field-type-names](https://user-images.githubusercontent.com/738383/160235200-9f90b2aa-7d1f-476f-86af-ff08ee884da7.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik merged pull request #3872: [NETBEANS-5599] PHP 8.1 Support: Pure intersection types

Posted by GitBox <gi...@apache.org>.
tmysik merged pull request #3872:
URL: https://github.com/apache/netbeans/pull/3872


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 commented on pull request #3872: [NETBEANS-5599] PHP 8.1 Support: Pure intersection types

Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #3872:
URL: https://github.com/apache/netbeans/pull/3872#issuecomment-1079693787


   @tmysik Could you please have a look at this when you have time? If there is no problem, let's merge it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] tmysik commented on pull request #3872: [NETBEANS-5599] PHP 8.1 Support: Pure intersection types

Posted by GitBox <gi...@apache.org>.
tmysik commented on pull request #3872:
URL: https://github.com/apache/netbeans/pull/3872#issuecomment-1079702640


   @junichi11 Thank you for working on the PHP support!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] junichi11 commented on pull request #3872: [NETBEANS-5599] PHP 8.1 Support: Pure intersection types

Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #3872:
URL: https://github.com/apache/netbeans/pull/3872#issuecomment-1079702375


   @tmysik Thank you for your quick review!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists