[jira] Updated: (HIVE-1068) CREATE VIEW followup: add a "table type" enum attribute in metastore's MTable, and also null out irrelevant attributes for MTable instances which describe views

["John Sichi (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-1068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Sichi updated HIVE-1068:
-----------------------------

    Attachment: HIVE-1068.1.patch

Notes for reviewers:

(1)

I introduced the new TableType enum in package o.a.h.h.metastore.  I didn't put it in metastore.api since it is not a generated file, and I didn't put it in metastore.model since that isn't accessed by most of Hive.  If there's a better place to put it, please let me know.

For the enum values, I used MANAGED_TABLE, EXTERNAL_TABLE, and VIRTUAL_VIEW.  This is so that later if we add MATERIALIZED_VIEW, there won't be any confusion.  If we eventually use this for implementing the TABLE_TYPE attribute in the ResultSet for JDBC's getTables, we can use a CASE expression to fold these into simpler names (e.g. JDBC uses "TABLE" and "VIEW").

(2)

I tried making the SerDe itself null, but that caused problems in too many places that were requiring it to be non-null.  So instead I nulled/emptied all of its attributes.


> CREATE VIEW followup:  add a "table type" enum attribute in metastore's MTable, and also null out irrelevant attributes for MTable instances which describe views
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-1068
>                 URL: https://issues.apache.org/jira/browse/HIVE-1068
>             Project: Hadoop Hive
>          Issue Type: Improvement
>          Components: Metastore
>    Affects Versions: 0.6.0
>            Reporter: John Sichi
>            Assignee: John Sichi
>             Fix For: 0.6.0
>
>         Attachments: HIVE-1068.1.patch
>
>
> Zheng's description:
> 5. TODO: Metadata change: We store "view" definitions in the same metadata table that we store "table" definitions.
> Shall we add a field "table type" so we know whether it's a table, external table, view, or materialized view in the future.
> We should clean up the additional useless fields in "view" - the test output shows that we are storing some garbage information for views.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.