[GitHub] [trafficcontrol] shamrickus commented on a diff in pull request #6928: Add the ability to TPv2 to add users

[GitBox <gi...@apache.org>]

shamrickus commented on code in PR #6928:
URL: https://github.com/apache/trafficcontrol/pull/6928#discussion_r921534549


##########
experimental/traffic-portal/src/app/core/users/users.component.html:
##########
@@ -25,3 +25,17 @@
 	</tp-generic-table>
 	<div id="loading" *ngIf="loading"><tp-loading></tp-loading></div>
 </mat-card>
+
+<button class="expandable-fab" type="button" (cdkMenuClosed)="toggleMenu('closed')" (cdkMenuOpened)="toggleMenu('opened')" mat-fab [cdkMenuTriggerFor]="menu" aria-label="Add a user" title="Add a user">
+	<mat-icon [ngClass]="{'open': menuIsOpen}">add</mat-icon>
+</button>
+<ng-template #menu>
+	<menu @fadeInOut @slideInOut cdkMenu>
+	  <a *ngIf="canCreateUsers()" cdkMenuItem routerLink="new" color="accent" mat-mini-fab aria-label="Create user from scratch" title="Create user from scratch">
+		<mat-icon>person_add</mat-icon>
+	  </a>
+	  <button cdkMenuItem color="accent" mat-mini-fab disabled>

Review Comment:
   Might be useful here to have a tooltip (aria-label most likely) explaining what this is like was done on the users table for change logs



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org