You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/03/04 12:24:25 UTC
[GitHub] [incubator-yunikorn-k8shim] youxuan0714 opened a new pull request #376: [YUNIKORN-1101] idempotent remove application and remove task in context
youxuan0714 opened a new pull request #376:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/376
### What is this PR for?
The shim context RemoveApplicationInternal and RemoveTask should not return an error if the application or task is not found.
I set the return value of RemoveApplicationInternal and RemoveTask to nil, so that no matter whether the task or application to be deleted exists or not, it will not return error.
Modify TestRemoveApplicationInternal and TestRemoveTask in context.go as expected.
### What type of PR is it?
* [ ] - Bug Fix
* [x] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
(https://issues.apache.org/jira/browse/YUNIKORN-1101)
### How should this be tested?
use "make test" command
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] 0yukali0 merged pull request #376: [YUNIKORN-1101] idempotent remove application and remove task in context
Posted by GitBox <gi...@apache.org>.
0yukali0 merged pull request #376:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on a change in pull request #376: [YUNIKORN-1101] idempotent remove application and remove task in context
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #376:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/376#discussion_r820168274
##########
File path: pkg/cache/context.go
##########
@@ -660,11 +660,8 @@ func (ctx *Context) RemoveApplication(appID string) error {
func (ctx *Context) RemoveApplicationInternal(appID string) error {
ctx.lock.Lock()
defer ctx.lock.Unlock()
- if _, exist := ctx.applications[appID]; exist {
- delete(ctx.applications, appID)
- return nil
- }
- return fmt.Errorf("application %s is not found in the context", appID)
+ delete(ctx.applications, appID)
Review comment:
`RemoveApplicationInternal` `RemoveTask` and `removeTask` all should not return an error. Just be silent and execute the remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #376: [YUNIKORN-1101] idempotent remove application and remove task in context
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #376:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/376#issuecomment-1059514886
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/376?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#376](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/376?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c075409) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/016bdd6d59d3d4ad279381774edab04090b63892?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (016bdd6) will **increase** coverage by `0.02%`.
> The diff coverage is `90.47%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #376 +/- ##
==========================================
+ Coverage 64.87% 64.90% +0.02%
==========================================
Files 41 41
Lines 6255 6254 -1
==========================================
+ Hits 4058 4059 +1
+ Misses 2042 2040 -2
Partials 155 155
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/cache/amprotocol\_mock.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/376/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL2FtcHJvdG9jb2xfbW9jay5nbw==) | `0.00% <0.00%> (ø)` | |
| [pkg/cache/application.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/376/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL2FwcGxpY2F0aW9uLmdv) | `71.74% <100.00%> (-0.06%)` | :arrow_down: |
| [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/376/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `43.06% <100.00%> (+0.16%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/376?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/376?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [016bdd6...c075409](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/376?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] 0yukali0 commented on a change in pull request #376: [YUNIKORN-1101] idempotent remove application and remove task in context
Posted by GitBox <gi...@apache.org>.
0yukali0 commented on a change in pull request #376:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/376#discussion_r820054836
##########
File path: pkg/cache/context.go
##########
@@ -660,11 +660,8 @@ func (ctx *Context) RemoveApplication(appID string) error {
func (ctx *Context) RemoveApplicationInternal(appID string) error {
ctx.lock.Lock()
defer ctx.lock.Unlock()
- if _, exist := ctx.applications[appID]; exist {
- delete(ctx.applications, appID)
- return nil
- }
- return fmt.Errorf("application %s is not found in the context", appID)
+ delete(ctx.applications, appID)
Review comment:
Hi @wilfred-s , should we keep the message as a log to remind user or just skip the the massage?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] youxuan0714 commented on a change in pull request #376: [YUNIKORN-1101] idempotent remove application and remove task in context
Posted by GitBox <gi...@apache.org>.
youxuan0714 commented on a change in pull request #376:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/376#discussion_r820173249
##########
File path: pkg/cache/context.go
##########
@@ -660,11 +660,8 @@ func (ctx *Context) RemoveApplication(appID string) error {
func (ctx *Context) RemoveApplicationInternal(appID string) error {
ctx.lock.Lock()
defer ctx.lock.Unlock()
- if _, exist := ctx.applications[appID]; exist {
- delete(ctx.applications, appID)
- return nil
- }
- return fmt.Errorf("application %s is not found in the context", appID)
+ delete(ctx.applications, appID)
Review comment:
Ok, I will try again, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] 0yukali0 commented on a change in pull request #376: [YUNIKORN-1101] idempotent remove application and remove task in context
Posted by GitBox <gi...@apache.org>.
0yukali0 commented on a change in pull request #376:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/376#discussion_r820054836
##########
File path: pkg/cache/context.go
##########
@@ -660,11 +660,8 @@ func (ctx *Context) RemoveApplication(appID string) error {
func (ctx *Context) RemoveApplicationInternal(appID string) error {
ctx.lock.Lock()
defer ctx.lock.Unlock()
- if _, exist := ctx.applications[appID]; exist {
- delete(ctx.applications, appID)
- return nil
- }
- return fmt.Errorf("application %s is not found in the context", appID)
+ delete(ctx.applications, appID)
Review comment:
Hi @wilfred-s , should we keep the message as a log to remind user or just skip the the message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #376: [YUNIKORN-1101] idempotent remove application and remove task in context
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #376:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/376#issuecomment-1059514886
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/376?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#376](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/376?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (311fb5f) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/016bdd6d59d3d4ad279381774edab04090b63892?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (016bdd6) will **not change** coverage.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #376 +/- ##
=======================================
Coverage 64.87% 64.87%
=======================================
Files 41 41
Lines 6255 6255
=======================================
Hits 4058 4058
Misses 2042 2042
Partials 155 155
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/376/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `42.89% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/376?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/376?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [016bdd6...311fb5f](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/376?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] 0yukali0 commented on a change in pull request #376: [YUNIKORN-1101] idempotent remove application and remove task in context
Posted by GitBox <gi...@apache.org>.
0yukali0 commented on a change in pull request #376:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/376#discussion_r820049701
##########
File path: pkg/cache/context.go
##########
@@ -660,11 +660,8 @@ func (ctx *Context) RemoveApplication(appID string) error {
func (ctx *Context) RemoveApplicationInternal(appID string) error {
ctx.lock.Lock()
defer ctx.lock.Unlock()
- if _, exist := ctx.applications[appID]; exist {
- delete(ctx.applications, appID)
- return nil
- }
- return fmt.Errorf("application %s is not found in the context", appID)
+ delete(ctx.applications, appID)
Review comment:
I think we can treat the message that shows the application doesn't exist as a log information.
Like you did in RemoveTask function.
`
if err != nil {
log.Logger().Info(" not found, it has been deleted",
zap.String("Application", appID))
}
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] 0yukali0 commented on a change in pull request #376: [YUNIKORN-1101] idempotent remove application and remove task in context
Posted by GitBox <gi...@apache.org>.
0yukali0 commented on a change in pull request #376:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/376#discussion_r820170572
##########
File path: pkg/cache/context.go
##########
@@ -660,11 +660,8 @@ func (ctx *Context) RemoveApplication(appID string) error {
func (ctx *Context) RemoveApplicationInternal(appID string) error {
ctx.lock.Lock()
defer ctx.lock.Unlock()
- if _, exist := ctx.applications[appID]; exist {
- delete(ctx.applications, appID)
- return nil
- }
- return fmt.Errorf("application %s is not found in the context", appID)
+ delete(ctx.applications, appID)
Review comment:
Thanks @wilfred-s, i got it.
Hi @youxuan0714, please move the message to debug level and change these functions with no error return.
You can review similar modification in YUNIKORN-1100(#375).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on a change in pull request #376: [YUNIKORN-1101] idempotent remove application and remove task in context
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #376:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/376#discussion_r820168116
##########
File path: pkg/cache/context.go
##########
@@ -660,11 +660,8 @@ func (ctx *Context) RemoveApplication(appID string) error {
func (ctx *Context) RemoveApplicationInternal(appID string) error {
ctx.lock.Lock()
defer ctx.lock.Unlock()
- if _, exist := ctx.applications[appID]; exist {
- delete(ctx.applications, appID)
- return nil
- }
- return fmt.Errorf("application %s is not found in the context", appID)
+ delete(ctx.applications, appID)
Review comment:
I would remove the whole return value from the call. We do not return errors as part of a `deleteNode` in the context as an example.
We can log a message, however we should not log it at a INFO level. DEBUG would be more appropriate for the log level. The message should then just say that we're removing the application or the task. Independent of the fact that the delete really happened. Again check `deleteNode` changes in YUNIKORN-1100 (#375)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] 0yukali0 commented on a change in pull request #376: [YUNIKORN-1101] idempotent remove application and remove task in context
Posted by GitBox <gi...@apache.org>.
0yukali0 commented on a change in pull request #376:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/376#discussion_r820049701
##########
File path: pkg/cache/context.go
##########
@@ -660,11 +660,8 @@ func (ctx *Context) RemoveApplication(appID string) error {
func (ctx *Context) RemoveApplicationInternal(appID string) error {
ctx.lock.Lock()
defer ctx.lock.Unlock()
- if _, exist := ctx.applications[appID]; exist {
- delete(ctx.applications, appID)
- return nil
- }
- return fmt.Errorf("application %s is not found in the context", appID)
+ delete(ctx.applications, appID)
Review comment:
I think we can treat the message that shows the application doesn't exist as a log information.
Like you did in RemoveTask function.
`
if err != nil {
log.Logger().Debug(" not found, it has been deleted",
zap.String("Application", appID))
}
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #376: [YUNIKORN-1101] idempotent remove application and remove task in context
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #376:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/376#issuecomment-1059514886
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/376?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#376](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/376?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (311fb5f) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/016bdd6d59d3d4ad279381774edab04090b63892?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (016bdd6) will **not change** coverage.
> The diff coverage is `100.00%`.
> :exclamation: Current head 311fb5f differs from pull request most recent head c075409. Consider uploading reports for the commit c075409 to get more accurate results
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #376 +/- ##
=======================================
Coverage 64.87% 64.87%
=======================================
Files 41 41
Lines 6255 6255
=======================================
Hits 4058 4058
Misses 2042 2042
Partials 155 155
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/376?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/cache/context.go](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/376/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL2NvbnRleHQuZ28=) | `42.89% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/376?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/376?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [016bdd6...c075409](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/376?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org