You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "villebro (via GitHub)" <gi...@apache.org> on 2025/03/06 04:30:01 UTC
[PR] fix: always extract query source from request [superset]
villebro opened a new pull request, #32525:
URL: https://github.com/apache/superset/pull/32525
### SUMMARY
This is a continuation of #32506. While testing the previous PR, I noticed that the query source was missing in many cases outside the db connection mutator context. It turns out there are many code paths that bypass the query source extraction part, causing the agent to be missing for most other cases than async SQL Lab queries.
This centralizes the request extraction logic in a single place, and falls back to checking the request referrer whenever the source isn't provided explicitly (this is usually the case for async tasks).
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: always extract query source from request [superset]
Posted by "korbit-ai[bot] (via GitHub)" <gi...@apache.org>.
korbit-ai[bot] commented on code in PR #32525:
URL: https://github.com/apache/superset/pull/32525#discussion_r1984109715
##########
superset/models/core.py:
##########
@@ -537,13 +537,7 @@
self.update_params_from_encrypted_extra(params)
if DB_CONNECTION_MUTATOR:
- if not source and request and request.referrer:
- if "/superset/dashboard/" in request.referrer:
- source = utils.QuerySource.DASHBOARD
- elif "/explore/" in request.referrer:
- source = utils.QuerySource.CHART
- elif "/sqllab/" in request.referrer:
- source = utils.QuerySource.SQL_LAB
+ source = source or get_query_source_from_request()
Review Comment:
### Query Source Determination Not Fully Centralized <sub></sub>
<details>
<summary>Tell me more</summary>
###### What is the issue?
The `source` parameter overrides the value from `get_query_source_from_request()`, which contradicts the intended centralization of query source determination.
###### Why this matters
If a source is directly passed as a parameter, it bypasses the centralized logic in `get_query_source_from_request()`. This defeats the purpose of having a single source of truth for query source determination.
###### Suggested change ∙ *Feature Preview*
Remove the `source` parameter override and exclusively use `get_query_source_from_request()`:
```python
source = get_query_source_from_request()
```
</details>
<sub>
[](https://app.korbit.ai/feedback/aa91ff46-6083-4491-9416-b83dd1994b51/b53d0b3b-2d8a-47c5-b8e2-c25e94ed90cc?suggestedFixEnabled=true)
💬 Looking for more details? Reply to this comment to chat with Korbit.
</sub>
<!--- korbi internal id:900a1621-6257-4c70-ab4e-4068a9f586bf -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: always extract query source from request [superset]
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro commented on code in PR #32525:
URL: https://github.com/apache/superset/pull/32525#discussion_r1984119913
##########
superset/models/core.py:
##########
@@ -537,13 +537,7 @@
self.update_params_from_encrypted_extra(params)
if DB_CONNECTION_MUTATOR:
- if not source and request and request.referrer:
- if "/superset/dashboard/" in request.referrer:
- source = utils.QuerySource.DASHBOARD
- elif "/explore/" in request.referrer:
- source = utils.QuerySource.CHART
- elif "/sqllab/" in request.referrer:
- source = utils.QuerySource.SQL_LAB
+ source = source or get_query_source_from_request()
Review Comment:
@korbit-ai I agree this isn't ideal. However, the reason why there's an explicit source that then falls back to the request referrer, is because these code paths are called both from synchronous flask request lifecycle AND asynchronously via Celery. When called via a Celery task, the source is passed along as a parameter, as there's no active flask request during that flow. For this reason we have this dual logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: always extract query source from request [superset]
Posted by "korbit-ai[bot] (via GitHub)" <gi...@apache.org>.
korbit-ai[bot] commented on PR #32525:
URL: https://github.com/apache/superset/pull/32525#issuecomment-2702778857
I was unable to post the issues I found. This could be because a force push or squash has changed the commit history since I scanned this pull request. You can get another review by commenting `/korbit-review`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: always extract query source from request [superset]
Posted by "korbit-ai[bot] (via GitHub)" <gi...@apache.org>.
korbit-ai[bot] commented on code in PR #32525:
URL: https://github.com/apache/superset/pull/32525#discussion_r1984120222
##########
superset/models/core.py:
##########
@@ -537,13 +537,7 @@
self.update_params_from_encrypted_extra(params)
if DB_CONNECTION_MUTATOR:
- if not source and request and request.referrer:
- if "/superset/dashboard/" in request.referrer:
- source = utils.QuerySource.DASHBOARD
- elif "/explore/" in request.referrer:
- source = utils.QuerySource.CHART
- elif "/sqllab/" in request.referrer:
- source = utils.QuerySource.SQL_LAB
+ source = source or get_query_source_from_request()
Review Comment:
@villebro Thank you for explaining the need for a dual logic to account for the sync and async use-cases. This analysis makes sense. It could be beneficial to consider encapsulating the dual logic (synchronous and asynchronous cases) in a separate method or class, so as to keep this logic in a centralized place to minimize any future confusion or errors. You could possibly also improve code readability by adding more detailed comments to explain the need for dual logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: always extract query source from request [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #32525:
URL: https://github.com/apache/superset/pull/32525#issuecomment-2705024356
/korbit-review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: always extract query source from request [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #32525:
URL: https://github.com/apache/superset/pull/32525#issuecomment-2702784001
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/32525?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `92.85714%` with `1 line` in your changes missing coverage. Please review.
> Project coverage is 65.68%. Comparing base [(`76d897e`)](https://app.codecov.io/gh/apache/superset/commit/76d897eaa2f9e137102bc194c2e3109c29d0348f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`909c6a0`)](https://app.codecov.io/gh/apache/superset/commit/909c6a03e861c8503414cd05d9efea00544b1b31?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 1541 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/32525?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [superset/models/core.py](https://app.codecov.io/gh/apache/superset/pull/32525?src=pr&el=tree&filepath=superset%2Fmodels%2Fcore.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/32525?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #32525 +/- ##
==========================================
+ Coverage 60.48% 65.68% +5.19%
==========================================
Files 1931 547 -1384
Lines 76236 39274 -36962
Branches 8568 0 -8568
==========================================
- Hits 46114 25797 -20317
+ Misses 28017 13477 -14540
+ Partials 2105 0 -2105
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/32525/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/32525/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.49% <21.42%> (-0.67%)` | :arrow_down: |
| [javascript](https://app.codecov.io/gh/apache/superset/pull/32525/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/32525/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.00% <21.42%> (-0.81%)` | :arrow_down: |
| [python](https://app.codecov.io/gh/apache/superset/pull/32525/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `65.68% <92.85%> (+2.19%)` | :arrow_up: |
| [unit](https://app.codecov.io/gh/apache/superset/pull/32525/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `61.24% <92.85%> (+3.61%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/32525?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary>🚀 New features to boost your workflow: </summary>
- ❄ [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- 📦 [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: always extract query source from request [superset]
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro merged PR #32525:
URL: https://github.com/apache/superset/pull/32525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org