You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/10/20 17:25:06 UTC
[GitHub] [beam] damondouglas opened a new pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
damondouglas opened a new pull request #15761:
URL: https://github.com/apache/beam/pull/15761
This PR creates gradle tasks for the Beam Playground project as well as a bundled `playgroundPrecommit` task. Future work needs to configure the precommit process to install necessary dependencies to properly run the `playgroundPrecommit` task. Note that when running `./gradlew playgroundPrecommit` in the current state will show multiple issues and errors in the playground code.
I'd like to request the following reviewers or whomever they delegate.
R: @pabloem
R: @tvalentyn
```
./gradlew playground:tasks
```
```
./gradlew playground:backend:tasks
```
```
./gradlew playground:frontend:tasks
```
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
`ValidatesRunner` compliance status (on master branch)
--------------------------------------------------------
<table>
<thead>
<tr>
<th>Lang</th>
<th>ULR</th>
<th>Dataflow</th>
<th>Flink</th>
<th>Samza</th>
<th>Spark</th>
<th>Twister2</th>
</tr>
</thead>
<tbody>
<tr>
<td>Go</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon">
</a>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Samza/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
<tr>
<td>Java</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_ULR/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_ULR/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon?subject=V1">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming/lastCompletedBuild/badge/icon?subject=V1+Streaming">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/badge/icon?subject=V1+Java+11">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2/lastCompletedBuild/badge/icon?subject=V2">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_VR_Dataflow_V2_Streaming/lastCompletedBuild/badge/icon?subject=V2+Streaming">
</a><br>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon?subject=Java+8">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/badge/icon?subject=Java+11">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon?subject=Portable">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon?subject=Portable+Streaming">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Samza/lastCompletedBuild/badge/icon?subject=Portable">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon?subject=Portable">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/badge/icon?subject=Structured+Streaming">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/badge/icon">
</a>
</td>
</tr>
<tr>
<td>Python</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/badge/icon?subject=V1">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/badge/icon?subject=V2">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon?subject=ValCont">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/badge/icon?subject=Portable">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Samza/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
<tr>
<td>XLang</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Dataflow/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Samza/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Samza/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
</tr>
</tbody>
</table>
Examples testing status on various runners
--------------------------------------------------------
<table>
<thead>
<tr>
<th>Lang</th>
<th>ULR</th>
<th>Dataflow</th>
<th>Flink</th>
<th>Samza</th>
<th>Spark</th>
<th>Twister2</th>
</tr>
</thead>
<tbody>
<tr>
<td>Go</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
<tr>
<td>Java</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Cron/lastCompletedBuild/badge/icon?subject=V1">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Java11_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Java11_Cron/lastCompletedBuild/badge/icon?subject=V1+Java11">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java_Examples_Dataflow_V2/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java_Examples_Dataflow_V2/lastCompletedBuild/badge/icon?subject=V2">
</a><br>
</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
<tr>
<td>Python</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
<tr>
<td>XLang</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
</tbody>
</table>
Post-Commit SDK/Transform Integration Tests Status (on master branch)
------------------------------------------------------------------------------------------------
<table>
<thead>
<tr>
<th>Go</th>
<th>Java</th>
<th>Python</th>
</tr>
</thead>
<tbody>
<tr>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/badge/icon?subject=3.6">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/badge/icon?subject=3.7">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/badge/icon?subject=3.8">
</a>
</td>
</tr>
</tbody>
</table>
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
<table>
<thead>
<tr>
<th>---</th>
<th>Java</th>
<th>Python</th>
<th>Go</th>
<th>Website</th>
<th>Whitespace</th>
<th>Typescript</th>
</tr>
</thead>
<tbody>
<tr>
<td>Non-portable</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/badge/icon">
</a><br>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/badge/icon?subject=Tests">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/badge/icon?subject=Lint">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/badge/icon?subject=Docker">
</a><br>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/badge/icon?subject=Docs">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Typescript_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
</tr>
<tr>
<td>Portable</td>
<td>---</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>
<a href="https://ci-beam.apache.org/job/beam_PreCommit_GoPortable_Cron/lastCompletedBuild/">
<img alt="Build Status" src="https://ci-beam.apache.org/job/beam_PreCommit_GoPortable_Cron/lastCompletedBuild/badge/icon">
</a>
</td>
<td>---</td>
<td>---</td>
<td>---</td>
</tr>
</tbody>
</table>
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #15761:
URL: https://github.com/apache/beam/pull/15761#issuecomment-948061388
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #15761:
URL: https://github.com/apache/beam/pull/15761#issuecomment-947898866
# [Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15761](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9e240cf) into [master](https://codecov.io/gh/apache/beam/commit/a05aa45dac5e7295a56634f0916b7019bc6782e5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a05aa45) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15761 +/- ##
==========================================
- Coverage 83.54% 83.53% -0.01%
==========================================
Files 445 445
Lines 61185 61185
==========================================
- Hits 51114 51109 -5
- Misses 10071 10076 +5
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `92.68% <0.00%> (-2.44%)` | :arrow_down: |
| [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `94.02% <0.00%> (-2.24%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.25% <0.00%> (-0.17%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a05aa45...9e240cf](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem merged pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
pabloem merged pull request #15761:
URL: https://github.com/apache/beam/pull/15761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damondouglas edited a comment on pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
damondouglas edited a comment on pull request #15761:
URL: https://github.com/apache/beam/pull/15761#issuecomment-947971569
(cc: @pabloem )
The following is the output running:
```
./gradlew playgroundPrecommit
```
@ilya-kozyrev would you mind to fix the following and make a PR to https://github.com/damondouglas/beam/tree/BEAM-13008-playground-build-gradle. Also you'll want to confirm that the `./gradlew playground:generateProto` task either generates in the right place or change the go dependencies.
```
> Task :playground:backend:tidy FAILED
go: finding module for package beam.apache.org/playground/backend/internal/environment
beam.apache.org/playground/backend/cmd/server imports
beam.apache.org/playground/backend/internal/environment: cannot find module providing package beam.apache.org/playground/backend/internal/environment: unrecognized import path "beam.apache.org/playground/backend/internal/environment": reading https://beam.apache.org/playground/backend/internal/environment?go-get=1: 404 Not Found
```
@ElessarST would you mind to fix the following and make a PR to https://github.com/damondouglas/beam/tree/BEAM-13008-playground-build-gradle.
1. For the mockito related errors, I realize there is this [SOF post](https://stackoverflow.com/questions/67927401/should-we-source-control-the-mocks-dart-files-created-by-build-runner-for-mocki) about commiting/notcommiting mockito generated code. I personally am in favor of commiting but I'll leave it to your judgement to figure out a way to make the `./gradlew playgroundPrecommit` pass either through another gradle task that would generate these dependencies.
2. Also you'll want to confirm that the `./gradlew playground:generateProto` task either generates in the right place or change the dart dependencies.
```
> Task :playground:frontend:analyze FAILED
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:21:8 - Target of URI doesn't exist: 'package:playground/generated/playground.pbgrpc.dart'. Try creating the file referenced by the URI, or Try using a URI for a file that does exist. - uri_does_not_exist
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:103:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:103:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:105:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:105:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:107:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:107:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:109:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:109:12 - Case expressions must be constant. - non_constant_case_expression
error - test/modules/editor/repository/code_repository/code_repository_test.dart:31:8 - Target of URI doesn't exist: 'code_repository_test.mocks.dart'. Try creating the file referenced by the URI, or Try using a URI for a file that does exist. - uri_does_not_exist
error - test/modules/editor/repository/code_repository/code_repository_test.dart:54:22 - The function 'MockCodeClient' isn't defined. Try importing the library that defines 'MockCodeClient', correcting the name to the name of an existing function, or defining a function named 'MockCodeClient'. - undefined_function
error - test/modules/editor/repository/code_repository/code_repository_test.dart:87:22 - The function 'MockCodeClient' isn't defined. Try importing the library that defines 'MockCodeClient', correcting the name to the name of an existing function, or defining a function named 'MockCodeClient'. - undefined_function
error - test/modules/editor/repository/code_repository/code_repository_test.dart:121:22 - The function 'MockCodeClient' isn't defined. Try importing the library that defines 'MockCodeClient', correcting the name to the name of an existing function, or defining a function named 'MockCodeClient'. - undefined_function
13 issues found.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damondouglas edited a comment on pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
damondouglas edited a comment on pull request #15761:
URL: https://github.com/apache/beam/pull/15761#issuecomment-947971569
(cc: @pabloem )
The following is the output running:
```
./gradlew playgroundPrecommit
```
@ilya-kozyrev would you mind to fix the following and make a PR to https://github.com/damondouglas/beam/tree/BEAM-13008-playground-build-gradle.
```
> Task :playground:backend:tidy FAILED
go: finding module for package beam.apache.org/playground/backend/internal/environment
beam.apache.org/playground/backend/cmd/server imports
beam.apache.org/playground/backend/internal/environment: cannot find module providing package beam.apache.org/playground/backend/internal/environment: unrecognized import path "beam.apache.org/playground/backend/internal/environment": reading https://beam.apache.org/playground/backend/internal/environment?go-get=1: 404 Not Found
```
@ElessarST would you mind to fix the following and make a PR to https://github.com/damondouglas/beam/tree/BEAM-13008-playground-build-gradle. For the mockito related errors, I realize there is this [SOF post](https://stackoverflow.com/questions/67927401/should-we-source-control-the-mocks-dart-files-created-by-build-runner-for-mocki) about commiting/notcommiting mockito generated code. I personally am in favor of commiting but I'll leave it to your judgement to figure out a way to make the `./gradlew playgroundPrecommit` pass either through another gradle task that would generate these dependencies.
> Task :playground:frontend:analyze FAILED
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:21:8 - Target of URI doesn't exist: 'package:playground/generated/playground.pbgrpc.dart'. Try creating the file referenced by the URI, or Try using a URI for a file that does exist. - uri_does_not_exist
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:103:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:103:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:105:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:105:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:107:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:107:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:109:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:109:12 - Case expressions must be constant. - non_constant_case_expression
error - test/modules/editor/repository/code_repository/code_repository_test.dart:31:8 - Target of URI doesn't exist: 'code_repository_test.mocks.dart'. Try creating the file referenced by the URI, or Try using a URI for a file that does exist. - uri_does_not_exist
error - test/modules/editor/repository/code_repository/code_repository_test.dart:54:22 - The function 'MockCodeClient' isn't defined. Try importing the library that defines 'MockCodeClient', correcting the name to the name of an existing function, or defining a function named 'MockCodeClient'. - undefined_function
error - test/modules/editor/repository/code_repository/code_repository_test.dart:87:22 - The function 'MockCodeClient' isn't defined. Try importing the library that defines 'MockCodeClient', correcting the name to the name of an existing function, or defining a function named 'MockCodeClient'. - undefined_function
error - test/modules/editor/repository/code_repository/code_repository_test.dart:121:22 - The function 'MockCodeClient' isn't defined. Try importing the library that defines 'MockCodeClient', correcting the name to the name of an existing function, or defining a function named 'MockCodeClient'. - undefined_function
13 issues found.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damondouglas commented on a change in pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
damondouglas commented on a change in pull request #15761:
URL: https://github.com/apache/beam/pull/15761#discussion_r733089458
##########
File path: build.gradle.kts
##########
@@ -249,6 +247,17 @@ task("goIntegrationTests") {
dependsOn(":runners:google-cloud-dataflow-java:worker:shadowJar")
}
+task("playgroundPreCommit") {
+ dependsOn(":playground:backend:format")
Review comment:
I removed both the go and dart format build tasks from `playgroundPreCommit`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #15761:
URL: https://github.com/apache/beam/pull/15761#issuecomment-947898866
# [Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15761](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b940ca0) into [master](https://codecov.io/gh/apache/beam/commit/a05aa45dac5e7295a56634f0916b7019bc6782e5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a05aa45) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15761 +/- ##
==========================================
- Coverage 83.52% 83.52% -0.01%
==========================================
Files 445 445
Lines 61185 61185
==========================================
- Hits 51107 51103 -4
- Misses 10078 10082 +4
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/testing/test\_stream\_service.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy90ZXN0X3N0cmVhbV9zZXJ2aWNlLnB5) | `88.37% <0.00%> (-4.66%)` | :arrow_down: |
| [...che\_beam/runners/interactive/interactive\_runner.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9ydW5uZXIucHk=) | `90.74% <0.00%> (-1.86%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `78.26% <0.00%> (-1.45%)` | :arrow_down: |
| [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `93.28% <0.00%> (-0.75%)` | :arrow_down: |
| [...runners/interactive/display/pcoll\_visualization.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9kaXNwbGF5L3Bjb2xsX3Zpc3VhbGl6YXRpb24ucHk=) | `86.36% <0.00%> (+0.50%)` | :arrow_up: |
| [...pache\_beam/runners/interactive/interactive\_beam.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9iZWFtLnB5) | `76.58% <0.00%> (+0.97%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a05aa45...b940ca0](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #15761:
URL: https://github.com/apache/beam/pull/15761#issuecomment-947898866
# [Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15761](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b8d9cd2) into [master](https://codecov.io/gh/apache/beam/commit/a05aa45dac5e7295a56634f0916b7019bc6782e5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a05aa45) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15761 +/- ##
==========================================
- Coverage 83.54% 83.53% -0.01%
==========================================
Files 445 445
Lines 61185 61185
==========================================
- Hits 51114 51109 -5
- Misses 10071 10076 +5
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `92.68% <0.00%> (-2.44%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=) | `88.47% <0.00%> (-1.39%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `91.37% <0.00%> (-0.35%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a05aa45...b8d9cd2](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on a change in pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
pabloem commented on a change in pull request #15761:
URL: https://github.com/apache/beam/pull/15761#discussion_r733013050
##########
File path: settings.gradle.kts
##########
@@ -187,6 +187,9 @@ include(":sdks:java:testing:load-tests")
include(":sdks:java:testing:test-utils")
include(":sdks:java:testing:tpcds")
include(":sdks:java:testing:watermarks")
+include(":playground")
+include(":playground:backend")
+include(":playground:frontend")
Review comment:
can you add these in alphabetical order? this would make it appear before sdks, since p goes before s : )
##########
File path: build.gradle.kts
##########
@@ -249,6 +247,17 @@ task("goIntegrationTests") {
dependsOn(":runners:google-cloud-dataflow-java:worker:shadowJar")
}
+task("playgroundPreCommit") {
+ dependsOn(":playground:backend:format")
Review comment:
would format modify the code? if so, then it should not be part of precommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damondouglas edited a comment on pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
damondouglas edited a comment on pull request #15761:
URL: https://github.com/apache/beam/pull/15761#issuecomment-947971569
(cc: @pabloem )
The following is the output running:
```
./gradlew playgroundPrecommit
```
@ilya-kozyrev would you mind to fix the following and make a PR to https://github.com/damondouglas/beam/tree/BEAM-13008-playground-build-gradle.
```
> Task :playground:backend:tidy FAILED
go: finding module for package beam.apache.org/playground/backend/internal/environment
beam.apache.org/playground/backend/cmd/server imports
beam.apache.org/playground/backend/internal/environment: cannot find module providing package beam.apache.org/playground/backend/internal/environment: unrecognized import path "beam.apache.org/playground/backend/internal/environment": reading https://beam.apache.org/playground/backend/internal/environment?go-get=1: 404 Not Found
```
@ElessarST would you mind to fix the following and make a PR to https://github.com/damondouglas/beam/tree/BEAM-13008-playground-build-gradle. For the mockito related errors, I realize there is this [SOF post](https://stackoverflow.com/questions/67927401/should-we-source-control-the-mocks-dart-files-created-by-build-runner-for-mocki) about commiting/notcommiting mockito generated code. I personally am in favor of commiting but I'll leave it to your judgement to figure out a way to make the `./gradlew playgroundPrecommit` pass either through another gradle task that would generate these dependencies.
```
> Task :playground:frontend:analyze FAILED
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:21:8 - Target of URI doesn't exist: 'package:playground/generated/playground.pbgrpc.dart'. Try creating the file referenced by the URI, or Try using a URI for a file that does exist. - uri_does_not_exist
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:103:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:103:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:105:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:105:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:107:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:107:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:109:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:109:12 - Case expressions must be constant. - non_constant_case_expression
error - test/modules/editor/repository/code_repository/code_repository_test.dart:31:8 - Target of URI doesn't exist: 'code_repository_test.mocks.dart'. Try creating the file referenced by the URI, or Try using a URI for a file that does exist. - uri_does_not_exist
error - test/modules/editor/repository/code_repository/code_repository_test.dart:54:22 - The function 'MockCodeClient' isn't defined. Try importing the library that defines 'MockCodeClient', correcting the name to the name of an existing function, or defining a function named 'MockCodeClient'. - undefined_function
error - test/modules/editor/repository/code_repository/code_repository_test.dart:87:22 - The function 'MockCodeClient' isn't defined. Try importing the library that defines 'MockCodeClient', correcting the name to the name of an existing function, or defining a function named 'MockCodeClient'. - undefined_function
error - test/modules/editor/repository/code_repository/code_repository_test.dart:121:22 - The function 'MockCodeClient' isn't defined. Try importing the library that defines 'MockCodeClient', correcting the name to the name of an existing function, or defining a function named 'MockCodeClient'. - undefined_function
13 issues found.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #15761:
URL: https://github.com/apache/beam/pull/15761#issuecomment-947898866
# [Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15761](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b940ca0) into [master](https://codecov.io/gh/apache/beam/commit/a05aa45dac5e7295a56634f0916b7019bc6782e5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a05aa45) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head b940ca0 differs from pull request most recent head f7fc854. Consider uploading reports for the commit f7fc854 to get more accurate results
[](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15761 +/- ##
==========================================
- Coverage 83.54% 83.52% -0.02%
==========================================
Files 445 445
Lines 61185 61185
==========================================
- Hits 51114 51103 -11
- Misses 10071 10082 +11
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/testing/test\_stream\_service.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy90ZXN0X3N0cmVhbV9zZXJ2aWNlLnB5) | `88.37% <0.00%> (-4.66%)` | :arrow_down: |
| [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `93.28% <0.00%> (-2.99%)` | :arrow_down: |
| [...che\_beam/runners/interactive/interactive\_runner.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9ydW5uZXIucHk=) | `90.74% <0.00%> (-1.86%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `78.26% <0.00%> (-1.45%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=) | `88.47% <0.00%> (-1.39%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.25% <0.00%> (-0.17%)` | :arrow_down: |
| [...runners/interactive/display/pcoll\_visualization.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9kaXNwbGF5L3Bjb2xsX3Zpc3VhbGl6YXRpb24ucHk=) | `86.36% <0.00%> (+0.50%)` | :arrow_up: |
| [...pache\_beam/runners/interactive/interactive\_beam.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9iZWFtLnB5) | `76.58% <0.00%> (+0.97%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a05aa45...f7fc854](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #15761:
URL: https://github.com/apache/beam/pull/15761#issuecomment-947898866
# [Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15761](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b940ca0) into [master](https://codecov.io/gh/apache/beam/commit/a05aa45dac5e7295a56634f0916b7019bc6782e5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a05aa45) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15761 +/- ##
==========================================
- Coverage 83.52% 83.52% -0.01%
==========================================
Files 445 445
Lines 61185 61185
==========================================
- Hits 51107 51103 -4
- Misses 10078 10082 +4
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/testing/test\_stream\_service.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy90ZXN0X3N0cmVhbV9zZXJ2aWNlLnB5) | `88.37% <0.00%> (-4.66%)` | :arrow_down: |
| [...che\_beam/runners/interactive/interactive\_runner.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9ydW5uZXIucHk=) | `90.74% <0.00%> (-1.86%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `78.26% <0.00%> (-1.45%)` | :arrow_down: |
| [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `93.28% <0.00%> (-0.75%)` | :arrow_down: |
| [...runners/interactive/display/pcoll\_visualization.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9kaXNwbGF5L3Bjb2xsX3Zpc3VhbGl6YXRpb24ucHk=) | `86.36% <0.00%> (+0.50%)` | :arrow_up: |
| [...pache\_beam/runners/interactive/interactive\_beam.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9iZWFtLnB5) | `76.58% <0.00%> (+0.97%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a05aa45...b940ca0](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damondouglas commented on a change in pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
damondouglas commented on a change in pull request #15761:
URL: https://github.com/apache/beam/pull/15761#discussion_r733105112
##########
File path: build.gradle.kts
##########
@@ -124,9 +124,7 @@ tasks.rat {
// Ignore Flutter autogenerated files for Playground
"playground/frontend/.metadata",
"playground/frontend/pubspec.lock",
- "playground/frontend/assets/**/*.svg",
- "playground/frontend/assets/**/*.png",
- "playground/frontend/assets/**/*.jpg",
+ "playground/frontend/**/*.svg",
Review comment:
@ElessarST @ilya-kozyrev (cc: @pabloem ) what is the license for these SVGs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #15761:
URL: https://github.com/apache/beam/pull/15761#issuecomment-947898866
# [Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15761](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b8d9cd2) into [master](https://codecov.io/gh/apache/beam/commit/a05aa45dac5e7295a56634f0916b7019bc6782e5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a05aa45) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head b8d9cd2 differs from pull request most recent head 9e240cf. Consider uploading reports for the commit 9e240cf to get more accurate results
[](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15761 +/- ##
==========================================
- Coverage 83.54% 83.53% -0.01%
==========================================
Files 445 445
Lines 61185 61185
==========================================
- Hits 51114 51109 -5
- Misses 10071 10076 +5
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `92.68% <0.00%> (-2.44%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=) | `88.47% <0.00%> (-1.39%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `91.37% <0.00%> (-0.35%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a05aa45...9e240cf](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damondouglas commented on pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
damondouglas commented on pull request #15761:
URL: https://github.com/apache/beam/pull/15761#issuecomment-948763495
@pabloem
```
./gradlew playgroundPrecommit
```
has the following output:
```
BUILD SUCCESSFUL in 21s
5 actionable tasks: 5 executed
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damondouglas edited a comment on pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
damondouglas edited a comment on pull request #15761:
URL: https://github.com/apache/beam/pull/15761#issuecomment-947971569
(cc: @pabloem )
The following is the output running:
```
./gradlew playgroundPrecommit
```
@ilya-kozyrev would you mind to fix the following and make a PR to https://github.com/damondouglas/beam/tree/BEAM-13008-playground-build-gradle. Also you'll want to confirm that the `./gradlew playground:generateProto` task either generates in the right place or change the go dependencies.
```
> Task :playground:backend:tidy FAILED
go: finding module for package beam.apache.org/playground/backend/internal/environment
beam.apache.org/playground/backend/cmd/server imports
beam.apache.org/playground/backend/internal/environment: cannot find module providing package beam.apache.org/playground/backend/internal/environment: unrecognized import path "beam.apache.org/playground/backend/internal/environment": reading https://beam.apache.org/playground/backend/internal/environment?go-get=1: 404 Not Found
```
@ElessarST would you mind to fix the following and make a PR to https://github.com/damondouglas/beam/tree/BEAM-13008-playground-build-gradle.
1. For the mockito related errors, I realize there is this [SOF post](https://stackoverflow.com/questions/67927401/should-we-source-control-the-mocks-dart-files-created-by-build-runner-for-mocki) about commiting/notcommiting mockito generated code. I personally am in favor of commiting but I'll leave it to your judgement to figure out a way to make the `./gradlew playgroundPrecommit` pass either through another gradle task that would generate these dependencies.
2. Also you'll want to confirm that the `./gradlew playground:generateProto` task either generates in the right place or change the go dependencies.
```
> Task :playground:frontend:analyze FAILED
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:21:8 - Target of URI doesn't exist: 'package:playground/generated/playground.pbgrpc.dart'. Try creating the file referenced by the URI, or Try using a URI for a file that does exist. - uri_does_not_exist
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:103:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:103:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:105:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:105:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:107:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:107:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:109:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:109:12 - Case expressions must be constant. - non_constant_case_expression
error - test/modules/editor/repository/code_repository/code_repository_test.dart:31:8 - Target of URI doesn't exist: 'code_repository_test.mocks.dart'. Try creating the file referenced by the URI, or Try using a URI for a file that does exist. - uri_does_not_exist
error - test/modules/editor/repository/code_repository/code_repository_test.dart:54:22 - The function 'MockCodeClient' isn't defined. Try importing the library that defines 'MockCodeClient', correcting the name to the name of an existing function, or defining a function named 'MockCodeClient'. - undefined_function
error - test/modules/editor/repository/code_repository/code_repository_test.dart:87:22 - The function 'MockCodeClient' isn't defined. Try importing the library that defines 'MockCodeClient', correcting the name to the name of an existing function, or defining a function named 'MockCodeClient'. - undefined_function
error - test/modules/editor/repository/code_repository/code_repository_test.dart:121:22 - The function 'MockCodeClient' isn't defined. Try importing the library that defines 'MockCodeClient', correcting the name to the name of an existing function, or defining a function named 'MockCodeClient'. - undefined_function
13 issues found.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #15761:
URL: https://github.com/apache/beam/pull/15761#issuecomment-947939766
have you ran this locally? can you share the output?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #15761:
URL: https://github.com/apache/beam/pull/15761#issuecomment-947898866
# [Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15761](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b940ca0) into [master](https://codecov.io/gh/apache/beam/commit/a05aa45dac5e7295a56634f0916b7019bc6782e5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a05aa45) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15761 +/- ##
==========================================
- Coverage 83.54% 83.52% -0.02%
==========================================
Files 445 445
Lines 61185 61185
==========================================
- Hits 51114 51103 -11
- Misses 10071 10082 +11
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/testing/test\_stream\_service.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy90ZXN0X3N0cmVhbV9zZXJ2aWNlLnB5) | `88.37% <0.00%> (-4.66%)` | :arrow_down: |
| [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `93.28% <0.00%> (-2.99%)` | :arrow_down: |
| [...che\_beam/runners/interactive/interactive\_runner.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9ydW5uZXIucHk=) | `90.74% <0.00%> (-1.86%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `78.26% <0.00%> (-1.45%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=) | `88.47% <0.00%> (-1.39%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.25% <0.00%> (-0.17%)` | :arrow_down: |
| [...runners/interactive/display/pcoll\_visualization.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9kaXNwbGF5L3Bjb2xsX3Zpc3VhbGl6YXRpb24ucHk=) | `86.36% <0.00%> (+0.50%)` | :arrow_up: |
| [...pache\_beam/runners/interactive/interactive\_beam.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9iZWFtLnB5) | `76.58% <0.00%> (+0.97%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a05aa45...b940ca0](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damondouglas commented on a change in pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
damondouglas commented on a change in pull request #15761:
URL: https://github.com/apache/beam/pull/15761#discussion_r733093367
##########
File path: settings.gradle.kts
##########
@@ -187,6 +187,9 @@ include(":sdks:java:testing:load-tests")
include(":sdks:java:testing:test-utils")
include(":sdks:java:testing:tpcds")
include(":sdks:java:testing:watermarks")
+include(":playground")
+include(":playground:backend")
+include(":playground:frontend")
Review comment:
Haha nice catch :-) Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #15761:
URL: https://github.com/apache/beam/pull/15761#issuecomment-947898866
# [Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15761](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b8d9cd2) into [master](https://codecov.io/gh/apache/beam/commit/a05aa45dac5e7295a56634f0916b7019bc6782e5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a05aa45) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15761 +/- ##
==========================================
- Coverage 83.54% 83.53% -0.01%
==========================================
Files 445 445
Lines 61185 61185
==========================================
- Hits 51114 51109 -5
- Misses 10071 10076 +5
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `92.68% <0.00%> (-2.44%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=) | `88.47% <0.00%> (-1.39%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `91.37% <0.00%> (-0.35%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a05aa45...b8d9cd2](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #15761:
URL: https://github.com/apache/beam/pull/15761#issuecomment-947898866
# [Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15761](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9e240cf) into [master](https://codecov.io/gh/apache/beam/commit/a05aa45dac5e7295a56634f0916b7019bc6782e5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a05aa45) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 9e240cf differs from pull request most recent head b0ff33f. Consider uploading reports for the commit b0ff33f to get more accurate results
[](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15761 +/- ##
==========================================
- Coverage 83.54% 83.53% -0.01%
==========================================
Files 445 445
Lines 61185 61185
==========================================
- Hits 51114 51109 -5
- Misses 10071 10076 +5
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `92.68% <0.00%> (-2.44%)` | :arrow_down: |
| [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `94.02% <0.00%> (-2.24%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.25% <0.00%> (-0.17%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a05aa45...b0ff33f](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #15761:
URL: https://github.com/apache/beam/pull/15761#issuecomment-948061320
LGTM. This is wonderful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #15761:
URL: https://github.com/apache/beam/pull/15761#issuecomment-947898866
# [Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15761](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b940ca0) into [master](https://codecov.io/gh/apache/beam/commit/a05aa45dac5e7295a56634f0916b7019bc6782e5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a05aa45) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
> :exclamation: Current head b940ca0 differs from pull request most recent head b8d9cd2. Consider uploading reports for the commit b8d9cd2 to get more accurate results
[](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15761 +/- ##
==========================================
- Coverage 83.54% 83.52% -0.02%
==========================================
Files 445 445
Lines 61185 61185
==========================================
- Hits 51114 51103 -11
- Misses 10071 10082 +11
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../python/apache\_beam/testing/test\_stream\_service.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdGVzdGluZy90ZXN0X3N0cmVhbV9zZXJ2aWNlLnB5) | `88.37% <0.00%> (-4.66%)` | :arrow_down: |
| [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `93.28% <0.00%> (-2.99%)` | :arrow_down: |
| [...che\_beam/runners/interactive/interactive\_runner.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9ydW5uZXIucHk=) | `90.74% <0.00%> (-1.86%)` | :arrow_down: |
| [...python/apache\_beam/runners/worker/worker\_status.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvd29ya2VyX3N0YXR1cy5weQ==) | `78.26% <0.00%> (-1.45%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=) | `88.47% <0.00%> (-1.39%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.25% <0.00%> (-0.17%)` | :arrow_down: |
| [...runners/interactive/display/pcoll\_visualization.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9kaXNwbGF5L3Bjb2xsX3Zpc3VhbGl6YXRpb24ucHk=) | `86.36% <0.00%> (+0.50%)` | :arrow_up: |
| [...pache\_beam/runners/interactive/interactive\_beam.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9iZWFtLnB5) | `76.58% <0.00%> (+0.97%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a05aa45...b8d9cd2](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damondouglas edited a comment on pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
damondouglas edited a comment on pull request #15761:
URL: https://github.com/apache/beam/pull/15761#issuecomment-947971569
(cc: @pabloem )
The following is the output running:
```
./gradlew playgroundPrecommit
```
@ilya-kozyrev would you mind to fix the following and make a PR to https://github.com/damondouglas/beam/tree/BEAM-13008-playground-build-gradle. Also you'll want to confirm that the `./gradlew playground:generateProto` task either generates in the right place or change the go dependency references.
```
> Task :playground:backend:tidy FAILED
go: finding module for package beam.apache.org/playground/backend/internal/environment
beam.apache.org/playground/backend/cmd/server imports
beam.apache.org/playground/backend/internal/environment: cannot find module providing package beam.apache.org/playground/backend/internal/environment: unrecognized import path "beam.apache.org/playground/backend/internal/environment": reading https://beam.apache.org/playground/backend/internal/environment?go-get=1: 404 Not Found
```
@ElessarST would you mind to fix the following and make a PR to https://github.com/damondouglas/beam/tree/BEAM-13008-playground-build-gradle.
1. For the mockito related errors, I realize there is this [SOF post](https://stackoverflow.com/questions/67927401/should-we-source-control-the-mocks-dart-files-created-by-build-runner-for-mocki) about commiting/notcommiting mockito generated code. I personally am in favor of commiting but I'll leave it to your judgement to figure out a way to make the `./gradlew playgroundPrecommit` pass either through another gradle task that would generate these dependencies.
2. Also you'll want to confirm that the `./gradlew playground:generateProto` task either generates in the right place or change the dart dependency references.
```
> Task :playground:frontend:analyze FAILED
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:21:8 - Target of URI doesn't exist: 'package:playground/generated/playground.pbgrpc.dart'. Try creating the file referenced by the URI, or Try using a URI for a file that does exist. - uri_does_not_exist
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:103:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:103:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:105:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:105:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:107:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:107:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:109:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:109:12 - Case expressions must be constant. - non_constant_case_expression
error - test/modules/editor/repository/code_repository/code_repository_test.dart:31:8 - Target of URI doesn't exist: 'code_repository_test.mocks.dart'. Try creating the file referenced by the URI, or Try using a URI for a file that does exist. - uri_does_not_exist
error - test/modules/editor/repository/code_repository/code_repository_test.dart:54:22 - The function 'MockCodeClient' isn't defined. Try importing the library that defines 'MockCodeClient', correcting the name to the name of an existing function, or defining a function named 'MockCodeClient'. - undefined_function
error - test/modules/editor/repository/code_repository/code_repository_test.dart:87:22 - The function 'MockCodeClient' isn't defined. Try importing the library that defines 'MockCodeClient', correcting the name to the name of an existing function, or defining a function named 'MockCodeClient'. - undefined_function
error - test/modules/editor/repository/code_repository/code_repository_test.dart:121:22 - The function 'MockCodeClient' isn't defined. Try importing the library that defines 'MockCodeClient', correcting the name to the name of an existing function, or defining a function named 'MockCodeClient'. - undefined_function
13 issues found.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damondouglas edited a comment on pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
damondouglas edited a comment on pull request #15761:
URL: https://github.com/apache/beam/pull/15761#issuecomment-947971569
(cc: @pabloem )
The following is the output running:
```
./gradlew playgroundPrecommit
```
@ilya-kozyrev would you mind to fix the following and make a PR to https://github.com/damondouglas/beam/tree/BEAM-13008-playground-build-gradle. Also you'll want to confirm that the `./gradlew playground:generateProto` task either generates in the right place or change the go dependencies.
```
> Task :playground:backend:tidy FAILED
go: finding module for package beam.apache.org/playground/backend/internal/environment
beam.apache.org/playground/backend/cmd/server imports
beam.apache.org/playground/backend/internal/environment: cannot find module providing package beam.apache.org/playground/backend/internal/environment: unrecognized import path "beam.apache.org/playground/backend/internal/environment": reading https://beam.apache.org/playground/backend/internal/environment?go-get=1: 404 Not Found
```
@ElessarST would you mind to fix the following and make a PR to https://github.com/damondouglas/beam/tree/BEAM-13008-playground-build-gradle.
1. For the mockito related errors, I realize there is this [SOF post](https://stackoverflow.com/questions/67927401/should-we-source-control-the-mocks-dart-files-created-by-build-runner-for-mocki) about commiting/notcommiting mockito generated code. I personally am in favor of commiting but I'll leave it to your judgement to figure out a way to make the `./gradlew playgroundPrecommit` pass either through another gradle task that would generate these dependencies.
2. Also you'll want to confirm that the `./gradlew playground:generateProto` task either generates in the right place or change the dart dependency references.
```
> Task :playground:frontend:analyze FAILED
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:21:8 - Target of URI doesn't exist: 'package:playground/generated/playground.pbgrpc.dart'. Try creating the file referenced by the URI, or Try using a URI for a file that does exist. - uri_does_not_exist
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:103:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:103:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:105:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:105:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:107:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:107:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:109:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:109:12 - Case expressions must be constant. - non_constant_case_expression
error - test/modules/editor/repository/code_repository/code_repository_test.dart:31:8 - Target of URI doesn't exist: 'code_repository_test.mocks.dart'. Try creating the file referenced by the URI, or Try using a URI for a file that does exist. - uri_does_not_exist
error - test/modules/editor/repository/code_repository/code_repository_test.dart:54:22 - The function 'MockCodeClient' isn't defined. Try importing the library that defines 'MockCodeClient', correcting the name to the name of an existing function, or defining a function named 'MockCodeClient'. - undefined_function
error - test/modules/editor/repository/code_repository/code_repository_test.dart:87:22 - The function 'MockCodeClient' isn't defined. Try importing the library that defines 'MockCodeClient', correcting the name to the name of an existing function, or defining a function named 'MockCodeClient'. - undefined_function
error - test/modules/editor/repository/code_repository/code_repository_test.dart:121:22 - The function 'MockCodeClient' isn't defined. Try importing the library that defines 'MockCodeClient', correcting the name to the name of an existing function, or defining a function named 'MockCodeClient'. - undefined_function
13 issues found.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damondouglas commented on pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
damondouglas commented on pull request #15761:
URL: https://github.com/apache/beam/pull/15761#issuecomment-947971569
(cc: @pabloem )
The following is the output running:
```
./gradlew playgroundPrecommit
```
@ilya-kozyrev would you mind to fix the following and make a PR to https://github.com/damondouglas/beam/tree/BEAM-13008-playground-build-gradle.
```
> Task :playground:backend:tidy FAILED
go: finding module for package beam.apache.org/playground/backend/internal/environment
beam.apache.org/playground/backend/cmd/server imports
beam.apache.org/playground/backend/internal/environment: cannot find module providing package beam.apache.org/playground/backend/internal/environment: unrecognized import path "beam.apache.org/playground/backend/internal/environment": reading https://beam.apache.org/playground/backend/internal/environment?go-get=1: 404 Not Found
```
@ElessarST would you mind to fix the following and make a PR to https://github.com/damondouglas/beam/tree/BEAM-13008-playground-build-gradle. For the mockito related errors, I realize there is this [SOF post](https://stackoverflow.com/questions/67927401/should-we-source-control-the-mocks-dart-files-created-by-build-runner-for-mocki) about commiting/notcommiting mockito generated code. I personally am in favor of commiting but I'll leave it to your judgement to figure out a way to make the `./gradlew playgroundPrecommit` pass either through another gradle task that would generate these dependencies.
> Task :playground:frontend:analyze FAILED
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:21:8 - Target of URI doesn't exist: 'package:playground/generated/playground.pbgrpc.dart'. Try creating the file referenced by the URI, or Try using a URI for a file that does exist. - uri_does_not_exist
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:103:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:103:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:105:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:105:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:107:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:107:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:109:12 - Case expressions must be constant. - non_constant_case_expression
error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:109:12 - Case expressions must be constant. - non_constant_case_expression
error - test/modules/editor/repository/code_repository/code_repository_test.dart:31:8 - Target of URI doesn't exist: 'code_repository_test.mocks.dart'. Try creating the file referenced by the URI, or Try using a URI for a file that does exist. - uri_does_not_exist
error - test/modules/editor/repository/code_repository/code_repository_test.dart:54:22 - The function 'MockCodeClient' isn't defined. Try importing the library that defines 'MockCodeClient', correcting the name to the name of an existing function, or defining a function named 'MockCodeClient'. - undefined_function
error - test/modules/editor/repository/code_repository/code_repository_test.dart:87:22 - The function 'MockCodeClient' isn't defined. Try importing the library that defines 'MockCodeClient', correcting the name to the name of an existing function, or defining a function named 'MockCodeClient'. - undefined_function
error - test/modules/editor/repository/code_repository/code_repository_test.dart:121:22 - The function 'MockCodeClient' isn't defined. Try importing the library that defines 'MockCodeClient', correcting the name to the name of an existing function, or defining a function named 'MockCodeClient'. - undefined_function
13 issues found.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #15761:
URL: https://github.com/apache/beam/pull/15761#issuecomment-947898866
# [Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15761](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b8d9cd2) into [master](https://codecov.io/gh/apache/beam/commit/a05aa45dac5e7295a56634f0916b7019bc6782e5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a05aa45) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15761 +/- ##
==========================================
- Coverage 83.54% 83.53% -0.01%
==========================================
Files 445 445
Lines 61185 61185
==========================================
- Hits 51114 51109 -5
- Misses 10071 10076 +5
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `92.68% <0.00%> (-2.44%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=) | `88.47% <0.00%> (-1.39%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `91.37% <0.00%> (-0.35%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a05aa45...b8d9cd2](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #15761:
URL: https://github.com/apache/beam/pull/15761#issuecomment-947898866
# [Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15761](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b8d9cd2) into [master](https://codecov.io/gh/apache/beam/commit/a05aa45dac5e7295a56634f0916b7019bc6782e5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a05aa45) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15761 +/- ##
==========================================
- Coverage 83.54% 83.53% -0.01%
==========================================
Files 445 445
Lines 61185 61185
==========================================
- Hits 51114 51109 -5
- Misses 10071 10076 +5
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `92.68% <0.00%> (-2.44%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=) | `88.47% <0.00%> (-1.39%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `91.37% <0.00%> (-0.35%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a05aa45...b8d9cd2](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #15761:
URL: https://github.com/apache/beam/pull/15761#issuecomment-947898866
# [Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15761](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b8d9cd2) into [master](https://codecov.io/gh/apache/beam/commit/a05aa45dac5e7295a56634f0916b7019bc6782e5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a05aa45) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15761 +/- ##
==========================================
- Coverage 83.54% 83.53% -0.01%
==========================================
Files 445 445
Lines 61185 61185
==========================================
- Hits 51114 51109 -5
- Misses 10071 10076 +5
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `92.68% <0.00%> (-2.44%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=) | `88.47% <0.00%> (-1.39%)` | :arrow_down: |
| [...eam/runners/interactive/interactive\_environment.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9pbnRlcmFjdGl2ZS9pbnRlcmFjdGl2ZV9lbnZpcm9ubWVudC5weQ==) | `91.37% <0.00%> (-0.35%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a05aa45...b8d9cd2](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #15761:
URL: https://github.com/apache/beam/pull/15761#issuecomment-947898866
# [Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15761](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b0ff33f) into [master](https://codecov.io/gh/apache/beam/commit/a05aa45dac5e7295a56634f0916b7019bc6782e5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a05aa45) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15761 +/- ##
==========================================
- Coverage 83.54% 83.52% -0.02%
==========================================
Files 445 445
Lines 61185 61185
==========================================
- Hits 51114 51107 -7
- Misses 10071 10078 +7
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `92.68% <0.00%> (-2.44%)` | :arrow_down: |
| [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `94.02% <0.00%> (-2.24%)` | :arrow_down: |
| [sdks/python/apache\_beam/io/source\_test\_utils.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vc291cmNlX3Rlc3RfdXRpbHMucHk=) | `88.47% <0.00%> (-1.39%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.25% <0.00%> (-0.17%)` | :arrow_down: |
| [...hon/apache\_beam/runners/worker/bundle\_processor.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvYnVuZGxlX3Byb2Nlc3Nvci5weQ==) | `93.64% <0.00%> (+0.12%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a05aa45...b0ff33f](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
pabloem commented on pull request #15761:
URL: https://github.com/apache/beam/pull/15761#issuecomment-948770668
LGTM. Merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] edited a comment on pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #15761:
URL: https://github.com/apache/beam/pull/15761#issuecomment-947898866
# [Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#15761](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9e240cf) into [master](https://codecov.io/gh/apache/beam/commit/a05aa45dac5e7295a56634f0916b7019bc6782e5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a05aa45) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #15761 +/- ##
==========================================
- Coverage 83.54% 83.53% -0.01%
==========================================
Files 445 445
Lines 61185 61185
==========================================
- Hits 51114 51109 -5
- Misses 10071 10076 +5
```
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=) | `92.68% <0.00%> (-2.44%)` | :arrow_down: |
| [...hon/apache\_beam/runners/direct/test\_stream\_impl.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kaXJlY3QvdGVzdF9zdHJlYW1faW1wbC5weQ==) | `94.02% <0.00%> (-2.24%)` | :arrow_down: |
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/15761/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.25% <0.00%> (-0.17%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a05aa45...9e240cf](https://codecov.io/gh/apache/beam/pull/15761?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ElessarST commented on pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
ElessarST commented on pull request #15761:
URL: https://github.com/apache/beam/pull/15761#issuecomment-948435177
@damondouglas I created PR with frontend changes https://github.com/damondouglas/beam/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] pabloem commented on a change in pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
pabloem commented on a change in pull request #15761:
URL: https://github.com/apache/beam/pull/15761#discussion_r733052051
##########
File path: build.gradle.kts
##########
@@ -249,6 +247,17 @@ task("goIntegrationTests") {
dependsOn(":runners:google-cloud-dataflow-java:worker:shadowJar")
}
+task("playgroundPreCommit") {
+ dependsOn(":playground:backend:format")
Review comment:
the auto-formatter would be part of the developer workflow, and the format-checker would be part of the precommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ilya-kozyrev commented on pull request #15761: [BEAM-13008] Create gradle tasks for the Beam Playground
Posted by GitBox <gi...@apache.org>.
ilya-kozyrev commented on pull request #15761:
URL: https://github.com/apache/beam/pull/15761#issuecomment-948620054
> (cc: @pabloem ) The following is the output running:
>
> ```
> ./gradlew playgroundPrecommit
> ```
>
> @ilya-kozyrev would you mind to fix the following and make a PR to https://github.com/damondouglas/beam/tree/BEAM-13008-playground-build-gradle. Also you'll want to confirm that the `./gradlew playground:generateProto` task either generates in the right place or change the go dependency references.
>
> ```
> > Task :playground:backend:tidy FAILED
> go: finding module for package beam.apache.org/playground/backend/internal/environment
> beam.apache.org/playground/backend/cmd/server imports
> beam.apache.org/playground/backend/internal/environment: cannot find module providing package beam.apache.org/playground/backend/internal/environment: unrecognized import path "beam.apache.org/playground/backend/internal/environment": reading https://beam.apache.org/playground/backend/internal/environment?go-get=1: 404 Not Found
> ```
>
> @ElessarST would you mind to fix the following and make a PR to https://github.com/damondouglas/beam/tree/BEAM-13008-playground-build-gradle.
>
> 1. For the mockito related errors, I realize there is this [SOF post](https://stackoverflow.com/questions/67927401/should-we-source-control-the-mocks-dart-files-created-by-build-runner-for-mocki) about commiting/notcommiting mockito generated code. I personally am in favor of commiting but I'll leave it to your judgement to figure out a way to make the `./gradlew playgroundPrecommit` pass either through another gradle task that would generate these dependencies.
> 2. Also you'll want to confirm that the `./gradlew playground:generateProto` task either generates in the right place or change the dart dependency references.
>
> ```
> > Task :playground:frontend:analyze FAILED
>
> error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:21:8 - Target of URI doesn't exist: 'package:playground/generated/playground.pbgrpc.dart'. Try creating the file referenced by the URI, or Try using a URI for a file that does exist. - uri_does_not_exist
> error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:103:12 - Case expressions must be constant. - non_constant_case_expression
> error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:103:12 - Case expressions must be constant. - non_constant_case_expression
> error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:105:12 - Case expressions must be constant. - non_constant_case_expression
> error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:105:12 - Case expressions must be constant. - non_constant_case_expression
> error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:107:12 - Case expressions must be constant. - non_constant_case_expression
> error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:107:12 - Case expressions must be constant. - non_constant_case_expression
> error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:109:12 - Case expressions must be constant. - non_constant_case_expression
> error - lib/modules/editor/repository/code_repository/code_client/grpc_code_client.dart:109:12 - Case expressions must be constant. - non_constant_case_expression
> error - test/modules/editor/repository/code_repository/code_repository_test.dart:31:8 - Target of URI doesn't exist: 'code_repository_test.mocks.dart'. Try creating the file referenced by the URI, or Try using a URI for a file that does exist. - uri_does_not_exist
> error - test/modules/editor/repository/code_repository/code_repository_test.dart:54:22 - The function 'MockCodeClient' isn't defined. Try importing the library that defines 'MockCodeClient', correcting the name to the name of an existing function, or defining a function named 'MockCodeClient'. - undefined_function
> error - test/modules/editor/repository/code_repository/code_repository_test.dart:87:22 - The function 'MockCodeClient' isn't defined. Try importing the library that defines 'MockCodeClient', correcting the name to the name of an existing function, or defining a function named 'MockCodeClient'. - undefined_function
> error - test/modules/editor/repository/code_repository/code_repository_test.dart:121:22 - The function 'MockCodeClient' isn't defined. Try importing the library that defines 'MockCodeClient', correcting the name to the name of an existing function, or defining a function named 'MockCodeClient'. - undefined_function
>
> 13 issues found.
> ```
@damondouglas Regarding this error
```
> Task :playground:backend:tidy FAILED
go: finding module for package beam.apache.org/playground/backend/internal/environment
beam.apache.org/playground/backend/cmd/server imports
beam.apache.org/playground/backend/internal/environment: cannot find module providing package beam.apache.org/playground/backend/internal/environment: unrecognized import path "beam.apache.org/playground/backend/internal/environment": reading https://beam.apache.org/playground/backend/internal/environment?go-get=1: 404 Not Found
```
It happened because we are still waiting for https://github.com/apache/beam/pull/15654 to get merged. Can we merge Environments first of all to resolve it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org