You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Brian Wickman <wi...@apache.org> on 2014/09/26 23:18:41 UTC
Review Request 26098: Fix checkstyle and add checkstyle back to
jenkins.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26098/
-----------------------------------------------------------
Review request for Aurora, Mark Chu-Carroll and Bill Farner.
Repository: aurora
Description
-------
Fix checkstyle and add checkstyle back to jenkins.
Diffs
-----
build-support/jenkins/build.sh 602b0bcd050cc8270b1f2c2ff3765f8e9319dd22
src/main/python/apache/aurora/admin/host_maintenance.py b7b339706e29b111459505e160209d3ad5d375e3
src/main/python/apache/aurora/client/api/__init__.py e1dfee7571b19f93fe4edfc0b7a81a3d496a09ba
src/main/python/apache/aurora/client/api/instance_watcher.py fe2f551fa81c32c9345a1552807f7726bf14977e
src/main/python/apache/aurora/client/api/job_monitor.py 756093dff8cf101158f2be803cc31f43ceabe654
src/main/python/apache/aurora/client/api/scheduler_client.py b400cb2dbdb35077fc2c4a6e161c2959a9217317
src/main/python/apache/aurora/client/api/updater_util.py 06eaf3d6b067bd6dd491d1cb6ffdebd5e905a649
src/main/python/apache/aurora/client/cli/context.py 102d20797816788361dfdac450aac9fb8e6fbc28
src/main/python/apache/aurora/client/cli/cron.py 33a6f91d0d4e4917980db2c79dba0142231fcfb5
src/main/python/apache/aurora/client/cli/jobs.py 6605485566c07b3e2c1f65b9372bb38e65af6ff9
src/main/python/apache/aurora/client/cli/standalone_client.py 30d8f750559b7811d66760741905fa8adf80fd1f
src/main/python/apache/aurora/client/cli/task.py 492dec101e500bb4d552f1fc0f06a953921f1ab1
src/main/python/apache/aurora/client/commands/core.py 5e6cedf1771411201b61f0108bee2e8cb19297b5
src/main/python/apache/aurora/client/commands/maintenance.py c83b96af2a2e6e47767d16ad9737c0fe3e0158eb
src/main/python/apache/aurora/client/commands/run.py 7ed22d35ec91dc95dc134960404071fdc6299b8c
src/main/python/apache/aurora/client/commands/ssh.py afd5ab767fbe8e66667b1fbbdb7a3cdefa7bfe6a
src/main/python/apache/aurora/executor/common/health_checker.py bed9aeeb982642b361a9c6477e95c255e41c5ff9
src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py c4ca3a26820562cb1c4ca94ad2b67ecb8c2a9d19
src/test/python/apache/aurora/client/api/test_api.py e1885f8f5a89104bd83a7ec717db399856563fd9
src/test/python/apache/aurora/client/api/test_scheduler_client.py 1cbfbf86e903d890baac7d34461109f9beaff442
src/test/python/apache/aurora/client/api/test_updater.py e4c9ad026323fc51ff8b9a2960abf9efdee6c898
src/test/python/apache/aurora/client/cli/test_cron.py 56f0bd4ba93cb9c1b94e58f549dad9d6b1894b22
src/test/python/apache/aurora/client/cli/test_update.py eeed774c170cbb8deacd533d33002aac4b2323cb
src/test/python/apache/aurora/client/commands/test_admin.py f2bf7b552f8de6feacc5548c792eea73a7560bef
src/test/python/apache/aurora/client/commands/test_kill.py 3e6d048590b07603540b3dab026c8fde3c3c4ba4
src/test/python/apache/aurora/client/commands/test_maintenance.py 004033bc82db503589b2b7bd815f651f4e3e844f
Diff: https://reviews.apache.org/r/26098/diff/
Testing
-------
Running build.sh now.
Thanks,
Brian Wickman
Re: Review Request 26098: Fix checkstyle and add checkstyle back to
jenkins.
Posted by Mark Chu-Carroll <mc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26098/#review55334
-----------------------------------------------------------
Ship it!
Ship It!
- Mark Chu-Carroll
On Sept. 26, 2014, 5:35 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26098/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2014, 5:35 p.m.)
>
>
> Review request for Aurora, Mark Chu-Carroll and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix checkstyle and add checkstyle back to jenkins.
>
>
> Diffs
> -----
>
> build-support/jenkins/build.sh 602b0bcd050cc8270b1f2c2ff3765f8e9319dd22
> src/main/python/apache/aurora/admin/host_maintenance.py b7b339706e29b111459505e160209d3ad5d375e3
> src/main/python/apache/aurora/client/api/__init__.py e1dfee7571b19f93fe4edfc0b7a81a3d496a09ba
> src/main/python/apache/aurora/client/api/instance_watcher.py fe2f551fa81c32c9345a1552807f7726bf14977e
> src/main/python/apache/aurora/client/api/job_monitor.py 756093dff8cf101158f2be803cc31f43ceabe654
> src/main/python/apache/aurora/client/api/scheduler_client.py b400cb2dbdb35077fc2c4a6e161c2959a9217317
> src/main/python/apache/aurora/client/api/updater_util.py 06eaf3d6b067bd6dd491d1cb6ffdebd5e905a649
> src/main/python/apache/aurora/client/cli/context.py 102d20797816788361dfdac450aac9fb8e6fbc28
> src/main/python/apache/aurora/client/cli/cron.py 33a6f91d0d4e4917980db2c79dba0142231fcfb5
> src/main/python/apache/aurora/client/cli/jobs.py 6605485566c07b3e2c1f65b9372bb38e65af6ff9
> src/main/python/apache/aurora/client/cli/standalone_client.py 30d8f750559b7811d66760741905fa8adf80fd1f
> src/main/python/apache/aurora/client/cli/task.py 492dec101e500bb4d552f1fc0f06a953921f1ab1
> src/main/python/apache/aurora/client/commands/core.py 5e6cedf1771411201b61f0108bee2e8cb19297b5
> src/main/python/apache/aurora/client/commands/maintenance.py c83b96af2a2e6e47767d16ad9737c0fe3e0158eb
> src/main/python/apache/aurora/client/commands/run.py 7ed22d35ec91dc95dc134960404071fdc6299b8c
> src/main/python/apache/aurora/client/commands/ssh.py afd5ab767fbe8e66667b1fbbdb7a3cdefa7bfe6a
> src/main/python/apache/aurora/executor/common/health_checker.py bed9aeeb982642b361a9c6477e95c255e41c5ff9
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py c4ca3a26820562cb1c4ca94ad2b67ecb8c2a9d19
> src/test/python/apache/aurora/client/api/test_api.py e1885f8f5a89104bd83a7ec717db399856563fd9
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 1cbfbf86e903d890baac7d34461109f9beaff442
> src/test/python/apache/aurora/client/api/test_updater.py e4c9ad026323fc51ff8b9a2960abf9efdee6c898
> src/test/python/apache/aurora/client/cli/test_cron.py 56f0bd4ba93cb9c1b94e58f549dad9d6b1894b22
> src/test/python/apache/aurora/client/cli/test_update.py eeed774c170cbb8deacd533d33002aac4b2323cb
> src/test/python/apache/aurora/client/commands/test_admin.py f2bf7b552f8de6feacc5548c792eea73a7560bef
> src/test/python/apache/aurora/client/commands/test_kill.py 3e6d048590b07603540b3dab026c8fde3c3c4ba4
> src/test/python/apache/aurora/client/commands/test_maintenance.py 004033bc82db503589b2b7bd815f651f4e3e844f
>
> Diff: https://reviews.apache.org/r/26098/diff/
>
>
> Testing
> -------
>
> Running build.sh now.
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 26098: Fix checkstyle and add checkstyle back to
jenkins.
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26098/#review55150
-----------------------------------------------------------
ping mark
- Brian Wickman
On Sept. 26, 2014, 9:35 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26098/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2014, 9:35 p.m.)
>
>
> Review request for Aurora, Mark Chu-Carroll and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix checkstyle and add checkstyle back to jenkins.
>
>
> Diffs
> -----
>
> build-support/jenkins/build.sh 602b0bcd050cc8270b1f2c2ff3765f8e9319dd22
> src/main/python/apache/aurora/admin/host_maintenance.py b7b339706e29b111459505e160209d3ad5d375e3
> src/main/python/apache/aurora/client/api/__init__.py e1dfee7571b19f93fe4edfc0b7a81a3d496a09ba
> src/main/python/apache/aurora/client/api/instance_watcher.py fe2f551fa81c32c9345a1552807f7726bf14977e
> src/main/python/apache/aurora/client/api/job_monitor.py 756093dff8cf101158f2be803cc31f43ceabe654
> src/main/python/apache/aurora/client/api/scheduler_client.py b400cb2dbdb35077fc2c4a6e161c2959a9217317
> src/main/python/apache/aurora/client/api/updater_util.py 06eaf3d6b067bd6dd491d1cb6ffdebd5e905a649
> src/main/python/apache/aurora/client/cli/context.py 102d20797816788361dfdac450aac9fb8e6fbc28
> src/main/python/apache/aurora/client/cli/cron.py 33a6f91d0d4e4917980db2c79dba0142231fcfb5
> src/main/python/apache/aurora/client/cli/jobs.py 6605485566c07b3e2c1f65b9372bb38e65af6ff9
> src/main/python/apache/aurora/client/cli/standalone_client.py 30d8f750559b7811d66760741905fa8adf80fd1f
> src/main/python/apache/aurora/client/cli/task.py 492dec101e500bb4d552f1fc0f06a953921f1ab1
> src/main/python/apache/aurora/client/commands/core.py 5e6cedf1771411201b61f0108bee2e8cb19297b5
> src/main/python/apache/aurora/client/commands/maintenance.py c83b96af2a2e6e47767d16ad9737c0fe3e0158eb
> src/main/python/apache/aurora/client/commands/run.py 7ed22d35ec91dc95dc134960404071fdc6299b8c
> src/main/python/apache/aurora/client/commands/ssh.py afd5ab767fbe8e66667b1fbbdb7a3cdefa7bfe6a
> src/main/python/apache/aurora/executor/common/health_checker.py bed9aeeb982642b361a9c6477e95c255e41c5ff9
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py c4ca3a26820562cb1c4ca94ad2b67ecb8c2a9d19
> src/test/python/apache/aurora/client/api/test_api.py e1885f8f5a89104bd83a7ec717db399856563fd9
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 1cbfbf86e903d890baac7d34461109f9beaff442
> src/test/python/apache/aurora/client/api/test_updater.py e4c9ad026323fc51ff8b9a2960abf9efdee6c898
> src/test/python/apache/aurora/client/cli/test_cron.py 56f0bd4ba93cb9c1b94e58f549dad9d6b1894b22
> src/test/python/apache/aurora/client/cli/test_update.py eeed774c170cbb8deacd533d33002aac4b2323cb
> src/test/python/apache/aurora/client/commands/test_admin.py f2bf7b552f8de6feacc5548c792eea73a7560bef
> src/test/python/apache/aurora/client/commands/test_kill.py 3e6d048590b07603540b3dab026c8fde3c3c4ba4
> src/test/python/apache/aurora/client/commands/test_maintenance.py 004033bc82db503589b2b7bd815f651f4e3e844f
>
> Diff: https://reviews.apache.org/r/26098/diff/
>
>
> Testing
> -------
>
> Running build.sh now.
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 26098: Fix checkstyle and add checkstyle back to
jenkins.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26098/#review55352
-----------------------------------------------------------
Ship it!
Thanks!
- Bill Farner
On Oct. 3, 2014, 4:38 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26098/
> -----------------------------------------------------------
>
> (Updated Oct. 3, 2014, 4:38 p.m.)
>
>
> Review request for Aurora, Mark Chu-Carroll and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix checkstyle and add checkstyle back to jenkins.
>
>
> Diffs
> -----
>
> build-support/jenkins/build.sh 850e08b1b82f368d452e3928eed8cbaadb418449
> src/main/python/apache/aurora/admin/host_maintenance.py b7b339706e29b111459505e160209d3ad5d375e3
> src/main/python/apache/aurora/client/api/__init__.py e1dfee7571b19f93fe4edfc0b7a81a3d496a09ba
> src/main/python/apache/aurora/client/api/instance_watcher.py fe2f551fa81c32c9345a1552807f7726bf14977e
> src/main/python/apache/aurora/client/api/job_monitor.py 756093dff8cf101158f2be803cc31f43ceabe654
> src/main/python/apache/aurora/client/api/scheduler_client.py b400cb2dbdb35077fc2c4a6e161c2959a9217317
> src/main/python/apache/aurora/client/api/updater_util.py 9bfc27da17f457218878cf3bdf378d38a99dd4cb
> src/main/python/apache/aurora/client/cli/context.py f639af7de93a069b278dc494b6f92a2f6b10de9c
> src/main/python/apache/aurora/client/cli/cron.py 33a6f91d0d4e4917980db2c79dba0142231fcfb5
> src/main/python/apache/aurora/client/cli/jobs.py 6605485566c07b3e2c1f65b9372bb38e65af6ff9
> src/main/python/apache/aurora/client/cli/standalone_client.py fd2232bc8b7e5caf487291f657a50184391a8c69
> src/main/python/apache/aurora/client/cli/task.py 492dec101e500bb4d552f1fc0f06a953921f1ab1
> src/main/python/apache/aurora/client/commands/core.py 5e6cedf1771411201b61f0108bee2e8cb19297b5
> src/main/python/apache/aurora/client/commands/maintenance.py c83b96af2a2e6e47767d16ad9737c0fe3e0158eb
> src/main/python/apache/aurora/client/commands/run.py 7ed22d35ec91dc95dc134960404071fdc6299b8c
> src/main/python/apache/aurora/client/commands/ssh.py afd5ab767fbe8e66667b1fbbdb7a3cdefa7bfe6a
> src/main/python/apache/aurora/executor/common/health_checker.py bed9aeeb982642b361a9c6477e95c255e41c5ff9
> src/main/python/apache/aurora/executor/gc_executor.py 44eb0da984a126536f0d277da3da128089201a47
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py c4ca3a26820562cb1c4ca94ad2b67ecb8c2a9d19
> src/test/python/apache/aurora/client/api/test_api.py 43370d8b83e03b66f72a2fe540c82740231422aa
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 1cbfbf86e903d890baac7d34461109f9beaff442
> src/test/python/apache/aurora/client/api/test_updater.py e4c9ad026323fc51ff8b9a2960abf9efdee6c898
> src/test/python/apache/aurora/client/cli/test_cron.py 56f0bd4ba93cb9c1b94e58f549dad9d6b1894b22
> src/test/python/apache/aurora/client/cli/test_update.py eeed774c170cbb8deacd533d33002aac4b2323cb
> src/test/python/apache/aurora/client/commands/test_admin.py f2bf7b552f8de6feacc5548c792eea73a7560bef
> src/test/python/apache/aurora/client/commands/test_kill.py 3e6d048590b07603540b3dab026c8fde3c3c4ba4
> src/test/python/apache/aurora/client/commands/test_maintenance.py 004033bc82db503589b2b7bd815f651f4e3e844f
> src/test/python/apache/aurora/executor/test_gc_executor.py 774c9ba0d5c31fc4c46dbe257579e013460fa943
>
> Diff: https://reviews.apache.org/r/26098/diff/
>
>
> Testing
> -------
>
> Running build.sh now.
>
>
> Thanks,
>
> Brian Wickman
>
>
Re: Review Request 26098: Fix checkstyle and add checkstyle back to
jenkins.
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26098/
-----------------------------------------------------------
(Updated Oct. 3, 2014, 4:38 p.m.)
Review request for Aurora, Mark Chu-Carroll and Bill Farner.
Changes
-------
Fix merge conflict and lapsed checkstyle.
Repository: aurora
Description
-------
Fix checkstyle and add checkstyle back to jenkins.
Diffs (updated)
-----
build-support/jenkins/build.sh 850e08b1b82f368d452e3928eed8cbaadb418449
src/main/python/apache/aurora/admin/host_maintenance.py b7b339706e29b111459505e160209d3ad5d375e3
src/main/python/apache/aurora/client/api/__init__.py e1dfee7571b19f93fe4edfc0b7a81a3d496a09ba
src/main/python/apache/aurora/client/api/instance_watcher.py fe2f551fa81c32c9345a1552807f7726bf14977e
src/main/python/apache/aurora/client/api/job_monitor.py 756093dff8cf101158f2be803cc31f43ceabe654
src/main/python/apache/aurora/client/api/scheduler_client.py b400cb2dbdb35077fc2c4a6e161c2959a9217317
src/main/python/apache/aurora/client/api/updater_util.py 9bfc27da17f457218878cf3bdf378d38a99dd4cb
src/main/python/apache/aurora/client/cli/context.py f639af7de93a069b278dc494b6f92a2f6b10de9c
src/main/python/apache/aurora/client/cli/cron.py 33a6f91d0d4e4917980db2c79dba0142231fcfb5
src/main/python/apache/aurora/client/cli/jobs.py 6605485566c07b3e2c1f65b9372bb38e65af6ff9
src/main/python/apache/aurora/client/cli/standalone_client.py fd2232bc8b7e5caf487291f657a50184391a8c69
src/main/python/apache/aurora/client/cli/task.py 492dec101e500bb4d552f1fc0f06a953921f1ab1
src/main/python/apache/aurora/client/commands/core.py 5e6cedf1771411201b61f0108bee2e8cb19297b5
src/main/python/apache/aurora/client/commands/maintenance.py c83b96af2a2e6e47767d16ad9737c0fe3e0158eb
src/main/python/apache/aurora/client/commands/run.py 7ed22d35ec91dc95dc134960404071fdc6299b8c
src/main/python/apache/aurora/client/commands/ssh.py afd5ab767fbe8e66667b1fbbdb7a3cdefa7bfe6a
src/main/python/apache/aurora/executor/common/health_checker.py bed9aeeb982642b361a9c6477e95c255e41c5ff9
src/main/python/apache/aurora/executor/gc_executor.py 44eb0da984a126536f0d277da3da128089201a47
src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py c4ca3a26820562cb1c4ca94ad2b67ecb8c2a9d19
src/test/python/apache/aurora/client/api/test_api.py 43370d8b83e03b66f72a2fe540c82740231422aa
src/test/python/apache/aurora/client/api/test_scheduler_client.py 1cbfbf86e903d890baac7d34461109f9beaff442
src/test/python/apache/aurora/client/api/test_updater.py e4c9ad026323fc51ff8b9a2960abf9efdee6c898
src/test/python/apache/aurora/client/cli/test_cron.py 56f0bd4ba93cb9c1b94e58f549dad9d6b1894b22
src/test/python/apache/aurora/client/cli/test_update.py eeed774c170cbb8deacd533d33002aac4b2323cb
src/test/python/apache/aurora/client/commands/test_admin.py f2bf7b552f8de6feacc5548c792eea73a7560bef
src/test/python/apache/aurora/client/commands/test_kill.py 3e6d048590b07603540b3dab026c8fde3c3c4ba4
src/test/python/apache/aurora/client/commands/test_maintenance.py 004033bc82db503589b2b7bd815f651f4e3e844f
src/test/python/apache/aurora/executor/test_gc_executor.py 774c9ba0d5c31fc4c46dbe257579e013460fa943
Diff: https://reviews.apache.org/r/26098/diff/
Testing
-------
Running build.sh now.
Thanks,
Brian Wickman
Re: Review Request 26098: Fix checkstyle and add checkstyle back to
jenkins.
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26098/
-----------------------------------------------------------
(Updated Sept. 26, 2014, 9:35 p.m.)
Review request for Aurora, Mark Chu-Carroll and Bill Farner.
Changes
-------
Actually -- the previous CL didn't exactly fix the problem -- pre-commit was still being run against master, which might fail due to git magic. Instead it should run against the src tree.
Repository: aurora
Description
-------
Fix checkstyle and add checkstyle back to jenkins.
Diffs (updated)
-----
build-support/jenkins/build.sh 602b0bcd050cc8270b1f2c2ff3765f8e9319dd22
src/main/python/apache/aurora/admin/host_maintenance.py b7b339706e29b111459505e160209d3ad5d375e3
src/main/python/apache/aurora/client/api/__init__.py e1dfee7571b19f93fe4edfc0b7a81a3d496a09ba
src/main/python/apache/aurora/client/api/instance_watcher.py fe2f551fa81c32c9345a1552807f7726bf14977e
src/main/python/apache/aurora/client/api/job_monitor.py 756093dff8cf101158f2be803cc31f43ceabe654
src/main/python/apache/aurora/client/api/scheduler_client.py b400cb2dbdb35077fc2c4a6e161c2959a9217317
src/main/python/apache/aurora/client/api/updater_util.py 06eaf3d6b067bd6dd491d1cb6ffdebd5e905a649
src/main/python/apache/aurora/client/cli/context.py 102d20797816788361dfdac450aac9fb8e6fbc28
src/main/python/apache/aurora/client/cli/cron.py 33a6f91d0d4e4917980db2c79dba0142231fcfb5
src/main/python/apache/aurora/client/cli/jobs.py 6605485566c07b3e2c1f65b9372bb38e65af6ff9
src/main/python/apache/aurora/client/cli/standalone_client.py 30d8f750559b7811d66760741905fa8adf80fd1f
src/main/python/apache/aurora/client/cli/task.py 492dec101e500bb4d552f1fc0f06a953921f1ab1
src/main/python/apache/aurora/client/commands/core.py 5e6cedf1771411201b61f0108bee2e8cb19297b5
src/main/python/apache/aurora/client/commands/maintenance.py c83b96af2a2e6e47767d16ad9737c0fe3e0158eb
src/main/python/apache/aurora/client/commands/run.py 7ed22d35ec91dc95dc134960404071fdc6299b8c
src/main/python/apache/aurora/client/commands/ssh.py afd5ab767fbe8e66667b1fbbdb7a3cdefa7bfe6a
src/main/python/apache/aurora/executor/common/health_checker.py bed9aeeb982642b361a9c6477e95c255e41c5ff9
src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py c4ca3a26820562cb1c4ca94ad2b67ecb8c2a9d19
src/test/python/apache/aurora/client/api/test_api.py e1885f8f5a89104bd83a7ec717db399856563fd9
src/test/python/apache/aurora/client/api/test_scheduler_client.py 1cbfbf86e903d890baac7d34461109f9beaff442
src/test/python/apache/aurora/client/api/test_updater.py e4c9ad026323fc51ff8b9a2960abf9efdee6c898
src/test/python/apache/aurora/client/cli/test_cron.py 56f0bd4ba93cb9c1b94e58f549dad9d6b1894b22
src/test/python/apache/aurora/client/cli/test_update.py eeed774c170cbb8deacd533d33002aac4b2323cb
src/test/python/apache/aurora/client/commands/test_admin.py f2bf7b552f8de6feacc5548c792eea73a7560bef
src/test/python/apache/aurora/client/commands/test_kill.py 3e6d048590b07603540b3dab026c8fde3c3c4ba4
src/test/python/apache/aurora/client/commands/test_maintenance.py 004033bc82db503589b2b7bd815f651f4e3e844f
Diff: https://reviews.apache.org/r/26098/diff/
Testing
-------
Running build.sh now.
Thanks,
Brian Wickman
Re: Review Request 26098: Fix checkstyle and add checkstyle back to
jenkins.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26098/#review54735
-----------------------------------------------------------
Ship it!
Beautiful
- Bill Farner
On Sept. 26, 2014, 9:18 p.m., Brian Wickman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26098/
> -----------------------------------------------------------
>
> (Updated Sept. 26, 2014, 9:18 p.m.)
>
>
> Review request for Aurora, Mark Chu-Carroll and Bill Farner.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Fix checkstyle and add checkstyle back to jenkins.
>
>
> Diffs
> -----
>
> build-support/jenkins/build.sh 602b0bcd050cc8270b1f2c2ff3765f8e9319dd22
> src/main/python/apache/aurora/admin/host_maintenance.py b7b339706e29b111459505e160209d3ad5d375e3
> src/main/python/apache/aurora/client/api/__init__.py e1dfee7571b19f93fe4edfc0b7a81a3d496a09ba
> src/main/python/apache/aurora/client/api/instance_watcher.py fe2f551fa81c32c9345a1552807f7726bf14977e
> src/main/python/apache/aurora/client/api/job_monitor.py 756093dff8cf101158f2be803cc31f43ceabe654
> src/main/python/apache/aurora/client/api/scheduler_client.py b400cb2dbdb35077fc2c4a6e161c2959a9217317
> src/main/python/apache/aurora/client/api/updater_util.py 06eaf3d6b067bd6dd491d1cb6ffdebd5e905a649
> src/main/python/apache/aurora/client/cli/context.py 102d20797816788361dfdac450aac9fb8e6fbc28
> src/main/python/apache/aurora/client/cli/cron.py 33a6f91d0d4e4917980db2c79dba0142231fcfb5
> src/main/python/apache/aurora/client/cli/jobs.py 6605485566c07b3e2c1f65b9372bb38e65af6ff9
> src/main/python/apache/aurora/client/cli/standalone_client.py 30d8f750559b7811d66760741905fa8adf80fd1f
> src/main/python/apache/aurora/client/cli/task.py 492dec101e500bb4d552f1fc0f06a953921f1ab1
> src/main/python/apache/aurora/client/commands/core.py 5e6cedf1771411201b61f0108bee2e8cb19297b5
> src/main/python/apache/aurora/client/commands/maintenance.py c83b96af2a2e6e47767d16ad9737c0fe3e0158eb
> src/main/python/apache/aurora/client/commands/run.py 7ed22d35ec91dc95dc134960404071fdc6299b8c
> src/main/python/apache/aurora/client/commands/ssh.py afd5ab767fbe8e66667b1fbbdb7a3cdefa7bfe6a
> src/main/python/apache/aurora/executor/common/health_checker.py bed9aeeb982642b361a9c6477e95c255e41c5ff9
> src/main/python/apache/aurora/tools/java/thrift_wrapper_codegen.py c4ca3a26820562cb1c4ca94ad2b67ecb8c2a9d19
> src/test/python/apache/aurora/client/api/test_api.py e1885f8f5a89104bd83a7ec717db399856563fd9
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 1cbfbf86e903d890baac7d34461109f9beaff442
> src/test/python/apache/aurora/client/api/test_updater.py e4c9ad026323fc51ff8b9a2960abf9efdee6c898
> src/test/python/apache/aurora/client/cli/test_cron.py 56f0bd4ba93cb9c1b94e58f549dad9d6b1894b22
> src/test/python/apache/aurora/client/cli/test_update.py eeed774c170cbb8deacd533d33002aac4b2323cb
> src/test/python/apache/aurora/client/commands/test_admin.py f2bf7b552f8de6feacc5548c792eea73a7560bef
> src/test/python/apache/aurora/client/commands/test_kill.py 3e6d048590b07603540b3dab026c8fde3c3c4ba4
> src/test/python/apache/aurora/client/commands/test_maintenance.py 004033bc82db503589b2b7bd815f651f4e3e844f
>
> Diff: https://reviews.apache.org/r/26098/diff/
>
>
> Testing
> -------
>
> Running build.sh now.
>
>
> Thanks,
>
> Brian Wickman
>
>