You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Damodar Reddy Talakanti <da...@citrix.com> on 2014/11/10 10:45:07 UTC
Re: Review Request 27222: Usage Events to be captured based on Volume
State Machine
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27222/
-----------------------------------------------------------
(Updated Nov. 10, 2014, 9:45 a.m.)
Review request for cloudstack, Kishan Kavala and Koushik Das.
Changes
-------
Updating the patch as it is not getting applied on the master
Bugs: CLOUDSTACK-7792
https://issues.apache.org/jira/browse/CLOUDSTACK-7792
Repository: cloudstack-git
Description
-------
Currently in CloudStack the Usage Events for Volume related actions are captured directly at various places.
But actually Volume has a State Machine which can be used to capture Usage Events for volume similar to VM Usage Events
Diffs (updated)
-----
api/src/com/cloud/storage/Volume.java 91ad955
api/src/com/cloud/vm/VirtualMachine.java 99152d6
engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/ObjectInDataStoreStateMachine.java b21616a
engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java 826e2ee
engine/schema/src/com/cloud/storage/VolumeVO.java e328253
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeObject.java f2b4c95
engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java 9c45cb8
server/src/com/cloud/storage/StorageManagerImpl.java 153c25a
server/src/com/cloud/storage/VolumeApiServiceImpl.java 088f054
server/src/com/cloud/storage/listener/VolumeStateListener.java 0ba2969
Diff: https://reviews.apache.org/r/27222/diff/
Testing
-------
Tested on Simulator. Also tested on XenServer for the following use cases
1. Add Volume (Migrate, Destroy)
2. Attach Volume (Live Migration and normal Migration)
3. Upload Volume (Attach also)
4. Delete Volume
5. Deploy VM (With Data Disk and with out Data Disk)
6. Destroy VM (With Data Disk and with out Data Disk)
7. Recover VM
8. Restore VM
9. Resize Volume
Thanks,
Damodar Reddy Talakanti
Re: Review Request 27222: Usage Events to be captured based on Volume
State Machine
Posted by Kishan Kavala <Ki...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27222/#review60560
-----------------------------------------------------------
Ship it!
master: 781648fb1003c8c32875e9ff7a6c4ef4694539f7
- Kishan Kavala
On Nov. 10, 2014, 3:15 p.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27222/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2014, 3:15 p.m.)
>
>
> Review request for cloudstack, Kishan Kavala and Koushik Das.
>
>
> Bugs: CLOUDSTACK-7792
> https://issues.apache.org/jira/browse/CLOUDSTACK-7792
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Currently in CloudStack the Usage Events for Volume related actions are captured directly at various places.
>
> But actually Volume has a State Machine which can be used to capture Usage Events for volume similar to VM Usage Events
>
>
> Diffs
> -----
>
> api/src/com/cloud/storage/Volume.java 91ad955
> api/src/com/cloud/vm/VirtualMachine.java 99152d6
> engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/ObjectInDataStoreStateMachine.java b21616a
> engine/orchestration/src/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java 826e2ee
> engine/schema/src/com/cloud/storage/VolumeVO.java e328253
> engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeObject.java f2b4c95
> engine/storage/volume/src/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java 9c45cb8
> server/src/com/cloud/storage/StorageManagerImpl.java 153c25a
> server/src/com/cloud/storage/VolumeApiServiceImpl.java 088f054
> server/src/com/cloud/storage/listener/VolumeStateListener.java 0ba2969
>
> Diff: https://reviews.apache.org/r/27222/diff/
>
>
> Testing
> -------
>
> Tested on Simulator. Also tested on XenServer for the following use cases
>
> 1. Add Volume (Migrate, Destroy)
> 2. Attach Volume (Live Migration and normal Migration)
> 3. Upload Volume (Attach also)
> 4. Delete Volume
> 5. Deploy VM (With Data Disk and with out Data Disk)
> 6. Destroy VM (With Data Disk and with out Data Disk)
> 7. Recover VM
> 8. Restore VM
> 9. Resize Volume
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>