You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2022/02/22 17:15:37 UTC
[GitHub] [drill] vdiravka opened a new pull request #2471: Fix flaky TestDrillbitResilience#memoryLeaksWhenCancelled test case
vdiravka opened a new pull request #2471:
URL: https://github.com/apache/drill/pull/2471
- changing timeout for TestDrillbitResilience tests
- timing tuning for memoryLeaksWhenCancelled
- update TestContainers version
# [DRILL-8145](https://issues.apache.org/jira/browse/DRILL-8145): Fix flaky TestDrillbitResilience#memoryLeaksWhenCancelled test case
## Description
Please check the description from [DRILL-8145](https://issues.apache.org/jira/browse/DRILL-8145)
## Documentation
N/A
## Testing
This PR fully about tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] vdiravka commented on pull request #2471: DRILL-8145: Fix flaky TestDrillbitResilience#memoryLeaksWhenCancelled test case
Posted by GitBox <gi...@apache.org>.
vdiravka commented on pull request #2471:
URL: https://github.com/apache/drill/pull/2471#issuecomment-1059987103
> @vdiravka, looks like you've nailed it! Can I convert this PR out of draft and review it?
Yes, I think it is ready. I didn't find optimal memory configs fo Travis build. Since there is [7.5Gb](https://docs.travis-ci.com/user/reference/overview/#virtualisation-environment-vs-operating-system) ENV memory limit. So there are 3 ways:
1. long term: optimize Drill memory usage, like it was earlier
2. to use paid plan for Travis.com builds
3. to disable 2 forks for Maven build for Travis, because it uses more memory, than one fork. So it will be longer, but it will be less loaded on memory.
I've chosen third for now and found the build still faster than GitHub CI builds. So the solution looks fine to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] jnturton commented on pull request #2471: Fix flaky TestDrillbitResilience#memoryLeaksWhenCancelled test case
Posted by GitBox <gi...@apache.org>.
jnturton commented on pull request #2471:
URL: https://github.com/apache/drill/pull/2471#issuecomment-1059895293
@vdiravka, looks like you've nailed it! Can I convert this PR out of draft and review it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [drill] jnturton merged pull request #2471: DRILL-8145: Fix flaky TestDrillbitResilience#memoryLeaksWhenCancelled test case
Posted by GitBox <gi...@apache.org>.
jnturton merged pull request #2471:
URL: https://github.com/apache/drill/pull/2471
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org