You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/11/11 05:56:24 UTC

[GitHub] [kafka] dengziming commented on a change in pull request #11261: KAFKA-13228: ApiVersionRequest is not properly handled in KRaft

dengziming commented on a change in pull request #11261:
URL: https://github.com/apache/kafka/pull/11261#discussion_r698029007



##########
File path: core/src/main/scala/kafka/admin/BrokerApiVersionsCommand.scala
##########
@@ -175,12 +171,12 @@ object BrokerApiVersionsCommand {
     }
 
     private def findAllBrokers(): List[Node] = {
-      val request = MetadataRequest.Builder.allTopics()
-      val response = sendAnyNode(request).asInstanceOf[MetadataResponse]
-      val errors = response.errors
+      val request = new DescribeClusterRequest.Builder(new DescribeClusterRequestData())

Review comment:
       `DescribeClusterRequestData` is more suitable here especially when there are too many topics.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org